diff mbox series

[for-next,v3] selftests/mm: Add a few missing gitignore files

Message ID 20241122074612.1582161-1-lizhijian@fujitsu.com
State Superseded
Headers show
Series [for-next,v3] selftests/mm: Add a few missing gitignore files | expand

Commit Message

Zhijian Li (Fujitsu) Nov. 22, 2024, 7:46 a.m. UTC
Compiled binary files should be added to .gitignore
'git status' complains:
   Untracked files:
   (use "git add <file>..." to include in what will be committed)
         mm/hugetlb_dio
         mm/pkey_sighandler_tests_32
         mm/pkey_sighandler_tests_64

Cc: Donet Tom <donettom@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
Cc: linux-mm@kvack.org
---
Hello,
Cover letter is here.

This patch set aims to make 'git status' clear after 'make' and 'make
run_tests' for kselftests.
---
V3:
   nothing change, just resend it
   (This .gitignore have not sorted, so I appended new files to the end)
V2:
  split as seperate patch from a small one [0]
  [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/
---
 tools/testing/selftests/mm/.gitignore | 2 ++
 1 file changed, 2 insertions(+)

Comments

John Hubbard Nov. 23, 2024, 6:42 a.m. UTC | #1
On 11/21/24 11:46 PM, Li Zhijian wrote:
> Compiled binary files should be added to .gitignore
> 'git status' complains:
>     Untracked files:
>     (use "git add <file>..." to include in what will be committed)
>           mm/hugetlb_dio
>           mm/pkey_sighandler_tests_32
>           mm/pkey_sighandler_tests_64
> 
> Cc: Donet Tom <donettom@linux.ibm.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Cc: linux-mm@kvack.org
> ---
> Hello,
> Cover letter is here.
> 
> This patch set aims to make 'git status' clear after 'make' and 'make
> run_tests' for kselftests.
> ---
> V3:
>     nothing change, just resend it
>     (This .gitignore have not sorted, so I appended new files to the end)
> V2:
>    split as seperate patch from a small one [0]
>    [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/
> ---
>   tools/testing/selftests/mm/.gitignore | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..2ac11b7fcb26 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,5 @@ hugetlb_madv_vs_map
>   mseal_test
>   seal_elf
>   droppable
> +hugetlb_dio
> +pkey_sighandler_tests*


Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
kernel test robot Nov. 25, 2024, 5:57 a.m. UTC | #2
Hi Li,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.12]
[cannot apply to akpm-mm/mm-everything linus/master next-20241122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Zhijian/selftests-mm-Add-a-few-missing-gitignore-files/20241125-095645
base:   v6.12
patch link:    https://lore.kernel.org/r/20241122074612.1582161-1-lizhijian%40fujitsu.com
patch subject: [PATCH for-next v3] selftests/mm: Add a few missing gitignore files
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20241125/202411251308.Vjm5MzVC-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411251308.Vjm5MzVC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411251308.Vjm5MzVC-lkp@intel.com/

All warnings (new ones prefixed by >>):

   tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
   tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
   tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>> tools/testing/selftests/mm/pkey_sighandler_tests.c: warning: ignored by one of the .gitignore files
John Hubbard Nov. 25, 2024, 8:38 p.m. UTC | #3
On 11/24/24 10:40 PM, Li Zhijian wrote:
> Compiled binary files should be added to .gitignore
> 'git status' complains:
>     Untracked files:
>     (use "git add <file>..." to include in what will be committed)
>           mm/hugetlb_dio
>           mm/pkey_sighandler_tests_32
>           mm/pkey_sighandler_tests_64
> 
> Cc: Donet Tom <donettom@linux.ibm.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> ---
> Cc: linux-mm@kvack.org
> ---
> 
> Hey John,
> I added your Reviewed-by tag in this revision which have a minor
> updates. Feel free to let me know if you feel this is unsuitable.
> 
> Hello,
> Cover letter is here.
> 
> This patch set aims to make 'git status' clear after 'make' and 'make
> run_tests' for kselftests.
> ---
> V4:
> 
>    Use the exact filename to fix warning reported by lkp@intel.com
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411251308.Vjm5MzVC-lkp@intel.com/
> V3:
>     nothing change, just resend it
>     (This .gitignore have not sorted, so I appended new files to the end)
> V2:
>    split as seperate patch from a small one [0]
>    [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/
> ---
>   tools/testing/selftests/mm/.gitignore | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..689bbd520296 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,6 @@ hugetlb_madv_vs_map
>   mseal_test
>   seal_elf
>   droppable
> +hugetlb_dio
> +pkey_sighandler_tests_32
> +pkey_sighandler_tests_64

Makes sense. Yes, this still looks good.

thanks,
diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
index da030b43e43b..2ac11b7fcb26 100644
--- a/tools/testing/selftests/mm/.gitignore
+++ b/tools/testing/selftests/mm/.gitignore
@@ -51,3 +51,5 @@  hugetlb_madv_vs_map
 mseal_test
 seal_elf
 droppable
+hugetlb_dio
+pkey_sighandler_tests*