| Message ID | 20241115193435.3618831-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: Remove unused and undocumented properties | expand |
On 12/16/2024 10:00 PM, Rob Herring wrote: > On Mon, Dec 16, 2024 at 6:42 AM Konrad Dybcio > <konrad.dybcio@oss.qualcomm.com> wrote: >> >> On 16.12.2024 4:42 AM, Aiqun Yu (Maria) wrote: >>> On 11/16/2024 3:36 AM, Konrad Dybcio wrote: >>>> On 15.11.2024 8:34 PM, Rob Herring (Arm) wrote: >>>>> Remove properties which are both unused in the kernel and undocumented. >>>>> Most likely they are leftovers from downstream. >>>>> >>>>> Signed-off-by: Rob Herring (Arm) <robh@kernel.org> >>>>> --- >>>> >>>> Funny, the sideinteraction compatible is undocumented and the touchscreen >>>> driver is not upstream >>> >>> Does the compatible also need to be fixed to "focaltech,ft8719"? Refer >>> to the info from [1]. >> >> +Alexander, Caleb - would you like to look into this on axolotl? >> >>> Confirmed, the compatible "focaltech,fts8719" is not even in any merged >>> bindings or drivers. Instead, "focaltech,ft8719" is in the current >>> driver and bindings. >>> >>> By the way, I am curious about how Rob finds the unused properties. >>> Could you share some steps? >> >> make ARCH=arm64 LLVM=1 -j24 CHECK_DTBS=1 dtbs >> >> returns all kinds of errors, including "undocumented property" > > This case however was a dtschema change I have not yet committed. > Plenty of other things to fix still with the above command though. :( Thanks, Rob and Konrad, for the clarification. That answers my question about the intention behind the current change.
diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi index 10cd244dea4f..4c983b10dd92 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi @@ -387,11 +387,6 @@ sideinteraction: touch@2c { interrupts = <&tlmm 96 IRQ_TYPE_EDGE_FALLING>; - button_num = <8>; - touchpad_num = <0>; - wheel_num = <0>; - slider_num = <0>; - vcc-supply = <&vreg_l18a_2p85>; }; diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts index 486ce175e6bc..ddb82ecb0a92 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts @@ -452,7 +452,6 @@ touchscreen@38 { irq-gpio = <&tlmm 125 GPIO_TRANSITORY>; touchscreen-size-x = <1080>; touchscreen-size-y = <2160>; - focaltech,max-touch-number = <5>; }; };
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi | 5 ----- arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 1 - 2 files changed, 6 deletions(-)