diff mbox

regulator: da9052: fix bug in device tree iteration loop

Message ID 1336377443-5926-1-git-send-email-paulliu@debian.org
State Accepted
Headers show

Commit Message

Ying-Chun Liu (PaulLiu) May 7, 2012, 7:57 a.m. UTC 
From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>

The driver of da9052 is buggy due to the iteration loop of device tree.
This patch fix the loop condition to make the driver work with device tree.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
---
 drivers/regulator/da9052-regulator.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown May 7, 2012, 11:52 a.m. UTC | #1 
On Mon, May 07, 2012 at 03:57:23PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>
> 
> The driver of da9052 is buggy due to the iteration loop of device tree.
> This patch fix the loop condition to make the driver work with device tree.

Applied, thanks.  I am wondering how this code was ever tested...
diff mbox

Patch

diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index eaa91cc5..f8ad24a 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -444,7 +444,7 @@  static int __devinit da9052_regulator_probe(struct platform_device *pdev)
 		if (!nproot)
 			return -ENODEV;
 
-		for (np = of_get_next_child(nproot, NULL); !np;
+		for (np = of_get_next_child(nproot, NULL); np;
 		     np = of_get_next_child(nproot, np)) {
 			if (!of_node_cmp(np->name,
 					 regulator->info->reg_desc.name)) {