diff mbox series

Revert "aplay: fix S24_LE wav header"

Message ID 20241113035938.2890202-1-shengjiu.wang@nxp.com
State New
Headers show
Series Revert "aplay: fix S24_LE wav header" | expand

Commit Message

Shengjiu Wang Nov. 13, 2024, 3:59 a.m. UTC 
S24_LE means the lower 24bit in 32bit space has valid data.
So previous code is correct. The commit causes regression,
then revert it.

This reverts commit 9cdcbe0e932b97fac88a6195f87647159a6c7194.

Fixes: 9cdcbe0e932b ("aplay: fix S24_LE wav header")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 aplay/aplay.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/aplay/aplay.c b/aplay/aplay.c
index c58c2e9..d11e63a 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -2719,11 +2719,11 @@  static void begin_wave(int fd, size_t cnt)
 	case SND_PCM_FORMAT_S16_LE:
 		bits = 16;
 		break;
-	case SND_PCM_FORMAT_S24_LE: /* S24_LE is 24 bits stored in 32 bit width with 8 bit padding */
 	case SND_PCM_FORMAT_S32_LE:
-	case SND_PCM_FORMAT_FLOAT_LE:
+        case SND_PCM_FORMAT_FLOAT_LE:
 		bits = 32;
 		break;
+	case SND_PCM_FORMAT_S24_LE:
 	case SND_PCM_FORMAT_S24_3LE:
 		bits = 24;
 		break;