| Message ID | 1480183585-592-12-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index ab59371..ae9a8d2 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1157,9 +1157,8 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip, read_oob_data(mtd, chip->oob_poi, denali->page); /* check ECC failures that may have occurred on erased pages */ - if (!is_erased(buf, mtd->writesize)) - mtd->ecc_stats.failed++; - if (!is_erased(chip->oob_poi, mtd->oobsize)) + if (!is_erased(buf, mtd->writesize) || + !is_erased(chip->oob_poi, mtd->oobsize)) mtd->ecc_stats.failed++; } return max_bitflips;
If the addressed page is not erased, the two calls of is_erase() will both return false, then mtd->ecc_stats.failed will be incremented by two. Rather, increment it by one because the whole page including OOB area is transferred in one transaction. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/denali.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.7.4