| Message ID | 20241102025635.586759-4-thiago.bauermann@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gdbserver improvements for AArch64 SVE support | expand |
On Saturday, November 2, 2024 3:56 AM, Thiago Jung Bauermann wrote: > This is useful information I missed while debugging issues with > the g packet reply. > --- > gdb/remote.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/remote.c b/gdb/remote.c > index b65a1c3094ae..6ffc51e4e2f5 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -10484,8 +10484,8 @@ remote_target::getpkt (gdb::char_vector *buf, bool forever, > bool *is_notif) > > if (val > max_chars) > remote_debug_printf_nofunc > - ("Packet received: %s [%d bytes omitted]", str.c_str (), > - val - max_chars); > + ("Packet received: %s [%d bytes omitted, %d bytes total]", str.c_str > (), Please note that the line is now too long -- goes to column 90. Nit: The message can also be shortened to "[%d of %d bytes omitted]". Reviewed-By: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
On 2024-12-20 10:09, Aktemur, Tankut Baris wrote: > On Saturday, November 2, 2024 3:56 AM, Thiago Jung Bauermann wrote: >> This is useful information I missed while debugging issues with >> the g packet reply. >> --- >> gdb/remote.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/remote.c b/gdb/remote.c >> index b65a1c3094ae..6ffc51e4e2f5 100644 >> --- a/gdb/remote.c >> +++ b/gdb/remote.c >> @@ -10484,8 +10484,8 @@ remote_target::getpkt (gdb::char_vector *buf, bool forever, >> bool *is_notif) >> >> if (val > max_chars) >> remote_debug_printf_nofunc >> - ("Packet received: %s [%d bytes omitted]", str.c_str (), >> - val - max_chars); >> + ("Packet received: %s [%d bytes omitted, %d bytes total]", str.c_str >> (), > > Please note that the line is now too long -- goes to column 90. > Nit: The message can also be shortened to "[%d of %d bytes omitted]". > > Reviewed-By: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> LGTM with that fixed. Approved-By: Simon Marchi <simon.marchi@efficios.com> Simon
Hello Baris, Hello Simon, Thank you for your reviews! Simon Marchi <simark@simark.ca> writes: > On 2024-12-20 10:09, Aktemur, Tankut Baris wrote: >> On Saturday, November 2, 2024 3:56 AM, Thiago Jung Bauermann wrote: >>> This is useful information I missed while debugging issues with >>> the g packet reply. >>> --- >>> gdb/remote.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/gdb/remote.c b/gdb/remote.c >>> index b65a1c3094ae..6ffc51e4e2f5 100644 >>> --- a/gdb/remote.c >>> +++ b/gdb/remote.c >>> @@ -10484,8 +10484,8 @@ remote_target::getpkt (gdb::char_vector *buf, bool forever, >>> bool *is_notif) >>> >>> if (val > max_chars) >>> remote_debug_printf_nofunc >>> - ("Packet received: %s [%d bytes omitted]", str.c_str (), >>> - val - max_chars); >>> + ("Packet received: %s [%d bytes omitted, %d bytes total]", str.c_str >>> (), >> >> Please note that the line is now too long -- goes to column 90. >> Nit: The message can also be shortened to "[%d of %d bytes omitted]". Indeed, I hadn't noticed. I adopted your wording, which brought the line to 80 columns. >> Reviewed-By: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> > LGTM with that fixed. > > Approved-By: Simon Marchi <simon.marchi@efficios.com> Thanks! Pushed as commit 1f493519f703 ("GDB: remote: Print total bytes received in debug message") -- Thiago
diff --git a/gdb/remote.c b/gdb/remote.c index b65a1c3094ae..6ffc51e4e2f5 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -10484,8 +10484,8 @@ remote_target::getpkt (gdb::char_vector *buf, bool forever, bool *is_notif) if (val > max_chars) remote_debug_printf_nofunc - ("Packet received: %s [%d bytes omitted]", str.c_str (), - val - max_chars); + ("Packet received: %s [%d bytes omitted, %d bytes total]", str.c_str (), + val - max_chars, val); else remote_debug_printf_nofunc ("Packet received: %s", str.c_str ());