| Message ID | 20241101111523.1293193-2-mtodorovac69@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] selftests/x86/syscall: fix coccinelle WARNING recommending the use of ARRAY_SIZE() | expand |
On 11/1/24 14:48, Peter Xu wrote: > On Fri, Nov 01, 2024 at 12:15:25PM +0100, Mirsad Todorovac wrote: >> Coccinelle gives WARNING recommending the use of ARRAY_SIZE() macro definition >> to improve the code readability: >> >> ./tools/testing/selftests/mm/uffd-unit-tests.c:1484:32-33: WARNING: Use ARRAY_SIZE >> ./tools/testing/selftests/mm/uffd-unit-tests.c:1485:30-31: WARNING: Use ARRAY_SIZE >> >> Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: Shuah Khan <shuah@kernel.org> >> Cc: Peter Xu <peterx@redhat.com> >> Cc: linux-mm@kvack.org >> Cc: linux-kselftest@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com> > > Acked-by: Peter Xu <peterx@redhat.com> Thanks for the quick review. Best regards, Mirsad
On 11/1/24 13:04, Muhammad Usama Anjum wrote: > On 11/1/24 4:15 PM, Mirsad Todorovac wrote: >> Coccinelle gives WARNING recommending the use of ARRAY_SIZE() macro definition >> to improve the code readability: >> >> ./tools/testing/selftests/x86/syscall_numbering.c:316:35-36: WARNING: Use ARRAY_SIZE >> >> Fixes: 15c82d98a0f78 ("selftests/x86/syscall: Update and extend syscall_numbering_64") >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Ingo Molnar <mingo@redhat.com> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: Dave Hansen <dave.hansen@linux.intel.com> >> Cc: x86@kernel.org >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Cc: Shuah Khan <shuah@kernel.org> >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-kselftest@vger.kernel.org >> Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com> > Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Dear Sir, Thank you for your positive review of the patch. There are much more suggestions by the coccinelle check, but that's a substantial work to do. It would help to set some priorities in this by some more experienced developer. Thank you. Best regards, Mirsad Todorovac >> --- >> v1: initial version. >> >> tools/testing/selftests/x86/syscall_numbering.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/x86/syscall_numbering.c b/tools/testing/selftests/x86/syscall_numbering.c >> index 991591718bb0..41c42b7b54a6 100644 >> --- a/tools/testing/selftests/x86/syscall_numbering.c >> +++ b/tools/testing/selftests/x86/syscall_numbering.c >> @@ -25,6 +25,7 @@ >> #include <sys/mman.h> >> >> #include <linux/ptrace.h> >> +#include "../kselftest.h" >> >> /* Common system call numbers */ >> #define SYS_READ 0 >> @@ -313,7 +314,7 @@ static void test_syscall_numbering(void) >> * The MSB is supposed to be ignored, so we loop over a few >> * to test that out. >> */ >> - for (size_t i = 0; i < sizeof(msbs)/sizeof(msbs[0]); i++) { >> + for (size_t i = 0; i < ARRAY_SIZE(msbs); i++) { >> int msb = msbs[i]; >> run("Checking system calls with msb = %d (0x%x)\n", >> msb, msb); >
diff --git a/tools/testing/selftests/x86/syscall_numbering.c b/tools/testing/selftests/x86/syscall_numbering.c index 991591718bb0..41c42b7b54a6 100644 --- a/tools/testing/selftests/x86/syscall_numbering.c +++ b/tools/testing/selftests/x86/syscall_numbering.c @@ -25,6 +25,7 @@ #include <sys/mman.h> #include <linux/ptrace.h> +#include "../kselftest.h" /* Common system call numbers */ #define SYS_READ 0 @@ -313,7 +314,7 @@ static void test_syscall_numbering(void) * The MSB is supposed to be ignored, so we loop over a few * to test that out. */ - for (size_t i = 0; i < sizeof(msbs)/sizeof(msbs[0]); i++) { + for (size_t i = 0; i < ARRAY_SIZE(msbs); i++) { int msb = msbs[i]; run("Checking system calls with msb = %d (0x%x)\n", msb, msb);
Coccinelle gives WARNING recommending the use of ARRAY_SIZE() macro definition to improve the code readability: ./tools/testing/selftests/x86/syscall_numbering.c:316:35-36: WARNING: Use ARRAY_SIZE Fixes: 15c82d98a0f78 ("selftests/x86/syscall: Update and extend syscall_numbering_64") Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: x86@kernel.org Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Shuah Khan <shuah@kernel.org> Cc: linux-kernel@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com> --- v1: initial version. tools/testing/selftests/x86/syscall_numbering.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)