| Message ID | 20241026090642.28633-1-surajsonawane0215@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] gpio: fix uninit-value in swnode_find_gpio | expand |
On 31/10/24 18:09, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > On Sat, 26 Oct 2024 14:36:42 +0530, Suraj Sonawane wrote: >> Fix an issue detected by the Smatch tool: >> >> drivers/gpio/gpiolib-swnode.c:78 swnode_find_gpio() error: >> uninitialized symbol 'ret'. >> >> The issue occurs because the 'ret' variable may be used without >> initialization if the for_each_gpio_property_name loop does not run. >> This could lead to returning an undefined value, causing unpredictable >> behavior. >> >> [...] > > Applied, thanks! > > [1/1] gpio: fix uninit-value in swnode_find_gpio > commit: a14968aea637bbe38a99e6089944e4ad8e6c49e5 > > Best regards, Thank you for applying this patch.
diff --git a/drivers/gpio/gpiolib-swnode.c b/drivers/gpio/gpiolib-swnode.c index 2b2dd7e92..51d2475c0 100644 --- a/drivers/gpio/gpiolib-swnode.c +++ b/drivers/gpio/gpiolib-swnode.c @@ -64,7 +64,7 @@ struct gpio_desc *swnode_find_gpio(struct fwnode_handle *fwnode, struct fwnode_reference_args args; struct gpio_desc *desc; char propname[32]; /* 32 is max size of property name */ - int ret; + int ret = 0; swnode = to_software_node(fwnode); if (!swnode)
Fix an issue detected by the Smatch tool: drivers/gpio/gpiolib-swnode.c:78 swnode_find_gpio() error: uninitialized symbol 'ret'. The issue occurs because the 'ret' variable may be used without initialization if the for_each_gpio_property_name loop does not run. This could lead to returning an undefined value, causing unpredictable behavior. Initialize 'ret' to 0 before the loop to ensure the function returns an error code if no properties are parsed, maintaining proper error handling. Fixes: 9e4c6c1ad ("Merge tag 'io_uring-6.12-20241011' of git://git.kernel.dk/linux") Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com> --- V1: https://lore.kernel.org/lkml/20241022194624.34223-1-surajsonawane0215@gmail.com/T/#u V2: Improved commit message. V3: Add fixes tag. drivers/gpio/gpiolib-swnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)