| Message ID | 20241007135133.5336-1-shayne.chen@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | [wireless] wifi: mt76: mt7996: fix invalid interface combinations | expand |
Hi this seems still not merged to next. can wireless/mtk Maintainer please pick this up? > Gesendet: Mittwoch, 9. Oktober 2024 um 19:23 > Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations > > Hi Shayne > > > Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr > > Von: "Shayne Chen" <shayne.chen@mediatek.com> > > Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations > > > > Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface > > combination is invalid, which will trigger the following warning trace > > and get error returned from wiphy_register(). > > > > [ 10.080325] Call trace: > > [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] > > [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] > > [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] > > [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e] > > > > Fix this by removing unused adhoc iftype. > > > > Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd") > > Reported-by: Frank Wunderlich <frank-w@public-files.de> > > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> > > thx for the patch. I can confirm it fixes the issue/trace. if tested-by is necessary: Tested-By: Frank Wunderlich <frank-w@public-files.de> > regards
Shayne Chen <shayne.chen@mediatek.com> wrote: > Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface > combination is invalid, which will trigger the following warning trace > and get error returned from wiphy_register(). > > [ 10.080325] Call trace: > [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] > [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] > [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] > [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e] > > Fix this by removing unused adhoc iftype. > > Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd") > Reported-by: Frank Wunderlich <frank-w@public-files.de> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> > Tested-By: Frank Wunderlich <frank-w@public-files.de> Patch applied to wireless-next.git, thanks. 89aca45f2687 wifi: mt76: mt7996: fix invalid interface combinations
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/net/wireless/mediatek/mt76/mt7996/init.c index f6a010b61a8a..2d36c7325137 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c @@ -16,9 +16,6 @@ static const struct ieee80211_iface_limit if_limits[] = { { - .max = 1, - .types = BIT(NL80211_IFTYPE_ADHOC) - }, { .max = 16, .types = BIT(NL80211_IFTYPE_AP) #ifdef CONFIG_MAC80211_MESH
Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface combination is invalid, which will trigger the following warning trace and get error returned from wiphy_register(). [ 10.080325] Call trace: [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211] [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211] [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76] [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e] Fix this by removing unused adhoc iftype. Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd") Reported-by: Frank Wunderlich <frank-w@public-files.de> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> --- drivers/net/wireless/mediatek/mt76/mt7996/init.c | 3 --- 1 file changed, 3 deletions(-)