| Message ID | 20241004-bcm63138-leds-v3-1-ba99a8e464b9@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: bcm63138: Add some new bindings and code | expand |
On 10/4/24 00:59, Linus Walleij wrote: > The BCM63138 family of serial LED controllers has a register > where we can set up bits for the shift registers. These are > the number of rounds the bits need to be shifted before all > bits have been shifted through the external shift registers. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Fri, 04 Oct 2024 09:59:22 +0200, Linus Walleij wrote: > The BCM63138 family of serial LED controllers has a register > where we can set up bits for the shift registers. These are > the number of rounds the bits need to be shifted before all > bits have been shifted through the external shift registers. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v2->v3: > - Mention that HW defaults will be used if the shift > register property is missing. > ChangeLog v1->v2: > - Drop the $ref to u32 since the new property is suffixed > with "-bits" and thus get standard treatment. > --- > Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml index bb20394fca5c..62326507c1aa 100644 --- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml +++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml @@ -41,6 +41,16 @@ properties: "#size-cells": const: 0 + brcm,serial-shift-bits: + minimum: 1 + maximum: 32 + description: + This describes the number of 8-bit serial shifters connected to the LED + controller block. The hardware is typically using 8-bit shift registers + with 8 LEDs per shift register, so 4 shifters results in 32 LEDs or 2 + shifters give 16 LEDs etc, but the hardware supports any odd number of + registers. If left unspecified, the hardware boot-time default is used. + patternProperties: "^led@[a-f0-9]+$": type: object @@ -71,6 +81,7 @@ examples: leds@ff800800 { compatible = "brcm,bcm4908-leds", "brcm,bcm63138-leds"; reg = <0xff800800 0xdc>; + brcm,serial-shift-bits = <16>; #address-cells = <1>; #size-cells = <0>;
The BCM63138 family of serial LED controllers has a register where we can set up bits for the shift registers. These are the number of rounds the bits need to be shifted before all bits have been shifted through the external shift registers. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v2->v3: - Mention that HW defaults will be used if the shift register property is missing. ChangeLog v1->v2: - Drop the $ref to u32 since the new property is suffixed with "-bits" and thus get standard treatment. --- Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)