diff mbox series

meson: fix machine option for x86_version

Message ID 20241004223715.1275428-1-pierrick.bouvier@linaro.org
State Superseded
Headers show
Series meson: fix machine option for x86_version | expand

Commit Message

Pierrick Bouvier Oct. 4, 2024, 10:37 p.m. UTC 
s/mbmi1/mbmi/

When configuring with -Dx86_version >= 3, meson step works, but
compilation fails because option -mbmi1 is unknown.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Bennée Oct. 5, 2024, 3:20 p.m. UTC | #1 
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> s/mbmi1/mbmi/
>
> When configuring with -Dx86_version >= 3, meson step works, but
> compilation fails because option -mbmi1 is unknown.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Michael Tokarev Oct. 5, 2024, 4:08 p.m. UTC | #2 
05.10.2024 01:37, Pierrick Bouvier пишет:
> s/mbmi1/mbmi/
> 
> When configuring with -Dx86_version >= 3, meson step works, but
> compilation fails because option -mbmi1 is unknown.

Fixes: v9.0.0-1771-gef7d1adfa8 "meson: allow configuring the x86-64 baseline"
Revieved-by: Michael Tokarev <mjt@tls.msk.ru>

Thanks,

/mjt
Michael Tokarev Oct. 5, 2024, 4:18 p.m. UTC | #3 
05.10.2024 19:08, Michael Tokarev wrote:
> 05.10.2024 01:37, Pierrick Bouvier wrote:
>> s/mbmi1/mbmi/
>>
>> When configuring with -Dx86_version >= 3, meson step works, but
>> compilation fails because option -mbmi1 is unknown.
> 
> Fixes: v9.0.0-1771-gef7d1adfa8 "meson: allow configuring the x86-64 baseline"
> Revieved-by: Michael Tokarev <mjt@tls.msk.ru>

Also marked this one for qemu-stable.

/mjt
Paolo Bonzini Oct. 6, 2024, 7:44 a.m. UTC | #4 
Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index af2ce595dcc..ebd914628c8 100644
--- a/meson.build
+++ b/meson.build
@@ -362,7 +362,7 @@  if host_arch in ['i386', 'x86_64']
     qemu_common_flags = cc.get_supported_arguments('-mneeded') + qemu_common_flags
   endif
   if get_option('x86_version') >= '3'
-    qemu_common_flags = ['-mmovbe', '-mabm', '-mbmi1', '-mbmi2', '-mfma', '-mf16c'] + qemu_common_flags
+    qemu_common_flags = ['-mmovbe', '-mabm', '-mbmi', '-mbmi2', '-mfma', '-mf16c'] + qemu_common_flags
   endif
 
   # add required vector instruction set (each level implies those below)