| Message ID | 20241004000015.544297-6-rosenp@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | devicetree: move nvmem-cells users to nvmem-layout | expand |
On 04/10/2024 02:00, Rosen Penev wrote: > nvmem-cells are deprecated and replaced with nvmem-layout. For these > examples, replace. They're not relevant to the main point of the > document anyway. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- > .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- > 2 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > index 1c2b4e780ca9..8ae149534b23 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > @@ -45,17 +45,20 @@ examples: > compatible = "qcom,smem-part"; > > partition-art { > - compatible = "nvmem-cells"; > - #address-cells = <1>; > - #size-cells = <1>; > label = "0:art"; > > - macaddr_art_0: macaddr@0 { > - reg = <0x0 0x6>; > - }; > + nvmem-layout { > + compatible = "fixed-layout"; This does not look right - the binding still expects nvmem-cells. I wonder how does the nvmem-cells.yaml work if the compatible is being removed so it is not being selected. Best regards, Krzysztof
On Thu, Oct 3, 2024 at 11:25 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/10/2024 02:00, Rosen Penev wrote: > > nvmem-cells are deprecated and replaced with nvmem-layout. For these > > examples, replace. They're not relevant to the main point of the > > document anyway. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > > > > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > > --- > > .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- > > .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- > > 2 files changed, 19 insertions(+), 13 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > > index 1c2b4e780ca9..8ae149534b23 100644 > > --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > > @@ -45,17 +45,20 @@ examples: > > compatible = "qcom,smem-part"; > > > > partition-art { > > - compatible = "nvmem-cells"; > > - #address-cells = <1>; > > - #size-cells = <1>; > > label = "0:art"; > > > > - macaddr_art_0: macaddr@0 { > > - reg = <0x0 0x6>; > > - }; > > + nvmem-layout { > > + compatible = "fixed-layout"; > > This does not look right - the binding still expects nvmem-cells. I > wonder how does the nvmem-cells.yaml work if the compatible is being > removed so it is not being selected. Not sure I follow here. You mean replace nvmem-cells.yaml with nvmem-layout.yaml ? > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml index 1c2b4e780ca9..8ae149534b23 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml @@ -45,17 +45,20 @@ examples: compatible = "qcom,smem-part"; partition-art { - compatible = "nvmem-cells"; - #address-cells = <1>; - #size-cells = <1>; label = "0:art"; - macaddr_art_0: macaddr@0 { - reg = <0x0 0x6>; - }; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + macaddr_art_0: macaddr@0 { + reg = <0x0 0x6>; + }; - macaddr_art_6: macaddr@6 { - reg = <0x6 0x6>; + macaddr_art_6: macaddr@6 { + reg = <0x6 0x6>; + }; }; }; }; diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml index 9854fab4c4db..5d118553228b 100644 --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml @@ -98,15 +98,18 @@ examples: /* ... */ partition@650000 { - compatible = "nvmem-cells"; label = "0:ethphyfw"; reg = <0x650000 0x80000>; read-only; - #address-cells = <1>; - #size-cells = <1>; - aqr_fw: aqr_fw@0 { - reg = <0x0 0x5f42a>; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + aqr_fw: aqr_fw@0 { + reg = <0x0 0x5f42a>; + }; }; };
nvmem-cells are deprecated and replaced with nvmem-layout. For these examples, replace. They're not relevant to the main point of the document anyway. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- 2 files changed, 19 insertions(+), 13 deletions(-)