| Message ID | 20240929074558.2076-3-andy-ld.lu@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add mtk-sd support for MT8196 | expand |
On Sun, Sep 29, 2024 at 03:44:06PM +0800, Andy-ld Lu wrote: > Extend the devicetree bindings to include the MT8196 mmc controller > by adding the compatible string 'mediatek,mt8196-mmc'. Your entire two-line sentence, says the same as commit msg and is pretty obvious from the diff. Say something useful instead, like describe the hardware differences. Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Sun, 2024-09-29 at 21:43 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Sun, Sep 29, 2024 at 03:44:06PM +0800, Andy-ld Lu wrote: > > Extend the devicetree bindings to include the MT8196 mmc controller > > by adding the compatible string 'mediatek,mt8196-mmc'. > > Your entire two-line sentence, says the same as commit msg and is > pretty > obvious from the diff. Say something useful instead, like describe > the > hardware differences. > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > Best regards, > Krzysztof Thanks for your suggestion, I would update in next change. >
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index c532ec92d2d9..9281a0326891 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -24,6 +24,7 @@ properties: - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc + - mediatek,mt8196-mmc - mediatek,mt8516-mmc - items: - const: mediatek,mt7623-mmc @@ -190,6 +191,7 @@ allOf: - mediatek,mt8186-mmc - mediatek,mt8188-mmc - mediatek,mt8195-mmc + - mediatek,mt8196-mmc - mediatek,mt8516-mmc then: properties:
Extend the devicetree bindings to include the MT8196 mmc controller by adding the compatible string 'mediatek,mt8196-mmc'. Signed-off-by: Andy-ld Lu <andy-ld.lu@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ 1 file changed, 2 insertions(+)