| Message ID | 20240926110137.2200158-4-quic_mahap@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Display enablement changes for Qualcomm SA8775P platform | expand |
On Thu, Sep 26, 2024 at 04:31:35PM GMT, Mahadevan wrote: > Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. > > Signed-off-by: Mahadevan <quic_mahap@quicinc.com> > --- > > [v2] > - Update commit message. [Dmitry] > - Reorder compatible string of MDSS based on alphabetical order. [Dmitry] > - add reg_bus_bw in msm_mdss_data. [Dmitry] > > --- > drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index faa88fd6eb4d..8f1d42a43bd0 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -573,6 +573,16 @@ static const struct msm_mdss_data qcm2290_data = { > .reg_bus_bw = 76800, > }; > > +static const struct msm_mdss_data sa8775p_data = { > + .ubwc_enc_version = UBWC_4_0, > + .ubwc_dec_version = UBWC_4_0, Just 4.0 or 4.3? > + .ubwc_swizzle = 4, > + .ubwc_static = 1, > + .highest_bank_bit = 0, > + .macrotile_mode = 1, > + .reg_bus_bw = 74000, > +}; > + > static const struct msm_mdss_data sc7180_data = { > .ubwc_enc_version = UBWC_2_0, > .ubwc_dec_version = UBWC_2_0, > @@ -710,6 +720,7 @@ static const struct of_device_id mdss_dt_match[] = { > { .compatible = "qcom,mdss" }, > { .compatible = "qcom,msm8998-mdss", .data = &msm8998_data }, > { .compatible = "qcom,qcm2290-mdss", .data = &qcm2290_data }, > + { .compatible = "qcom,sa8775p-mdss", .data = &sa8775p_data }, > { .compatible = "qcom,sdm670-mdss", .data = &sdm670_data }, > { .compatible = "qcom,sdm845-mdss", .data = &sdm845_data }, > { .compatible = "qcom,sc7180-mdss", .data = &sc7180_data }, > -- > 2.34.1 >
On 9/26/2024 6:32 PM, Dmitry Baryshkov wrote: > On Thu, Sep 26, 2024 at 04:31:35PM GMT, Mahadevan wrote: >> Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. >> >> Signed-off-by: Mahadevan <quic_mahap@quicinc.com> >> --- >> >> [v2] >> - Update commit message. [Dmitry] >> - Reorder compatible string of MDSS based on alphabetical order. [Dmitry] >> - add reg_bus_bw in msm_mdss_data. [Dmitry] >> >> --- >> drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c >> index faa88fd6eb4d..8f1d42a43bd0 100644 >> --- a/drivers/gpu/drm/msm/msm_mdss.c >> +++ b/drivers/gpu/drm/msm/msm_mdss.c >> @@ -573,6 +573,16 @@ static const struct msm_mdss_data qcm2290_data = { >> .reg_bus_bw = 76800, >> }; >> >> +static const struct msm_mdss_data sa8775p_data = { >> + .ubwc_enc_version = UBWC_4_0, >> + .ubwc_dec_version = UBWC_4_0, > Just 4.0 or 4.3? UBWC version has to be 4.0 as per UBWC reference document of sa8775p. > >> + .ubwc_swizzle = 4, >> + .ubwc_static = 1, >> + .highest_bank_bit = 0, >> + .macrotile_mode = 1, >> + .reg_bus_bw = 74000, >> +}; >> + >> static const struct msm_mdss_data sc7180_data = { >> .ubwc_enc_version = UBWC_2_0, >> .ubwc_dec_version = UBWC_2_0, >> @@ -710,6 +720,7 @@ static const struct of_device_id mdss_dt_match[] = { >> { .compatible = "qcom,mdss" }, >> { .compatible = "qcom,msm8998-mdss", .data = &msm8998_data }, >> { .compatible = "qcom,qcm2290-mdss", .data = &qcm2290_data }, >> + { .compatible = "qcom,sa8775p-mdss", .data = &sa8775p_data }, >> { .compatible = "qcom,sdm670-mdss", .data = &sdm670_data }, >> { .compatible = "qcom,sdm845-mdss", .data = &sdm845_data }, >> { .compatible = "qcom,sc7180-mdss", .data = &sc7180_data }, >> -- >> 2.34.1 >>
On Fri, Sep 27, 2024 at 12:14:16PM GMT, Mahadevan P wrote: > > On 9/26/2024 6:32 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 26, 2024 at 04:31:35PM GMT, Mahadevan wrote: > > > Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. > > > > > > Signed-off-by: Mahadevan <quic_mahap@quicinc.com> > > > --- > > > > > > [v2] > > > - Update commit message. [Dmitry] > > > - Reorder compatible string of MDSS based on alphabetical order. [Dmitry] > > > - add reg_bus_bw in msm_mdss_data. [Dmitry] > > > > > > --- > > > drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > > > index faa88fd6eb4d..8f1d42a43bd0 100644 > > > --- a/drivers/gpu/drm/msm/msm_mdss.c > > > +++ b/drivers/gpu/drm/msm/msm_mdss.c > > > @@ -573,6 +573,16 @@ static const struct msm_mdss_data qcm2290_data = { > > > .reg_bus_bw = 76800, > > > }; > > > +static const struct msm_mdss_data sa8775p_data = { > > > + .ubwc_enc_version = UBWC_4_0, > > > + .ubwc_dec_version = UBWC_4_0, > > Just 4.0 or 4.3? > > > UBWC version has to be 4.0 as per UBWC reference document of sa8775p. Thanks for the confirmation.
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index faa88fd6eb4d..8f1d42a43bd0 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -573,6 +573,16 @@ static const struct msm_mdss_data qcm2290_data = { .reg_bus_bw = 76800, }; +static const struct msm_mdss_data sa8775p_data = { + .ubwc_enc_version = UBWC_4_0, + .ubwc_dec_version = UBWC_4_0, + .ubwc_swizzle = 4, + .ubwc_static = 1, + .highest_bank_bit = 0, + .macrotile_mode = 1, + .reg_bus_bw = 74000, +}; + static const struct msm_mdss_data sc7180_data = { .ubwc_enc_version = UBWC_2_0, .ubwc_dec_version = UBWC_2_0, @@ -710,6 +720,7 @@ static const struct of_device_id mdss_dt_match[] = { { .compatible = "qcom,mdss" }, { .compatible = "qcom,msm8998-mdss", .data = &msm8998_data }, { .compatible = "qcom,qcm2290-mdss", .data = &qcm2290_data }, + { .compatible = "qcom,sa8775p-mdss", .data = &sa8775p_data }, { .compatible = "qcom,sdm670-mdss", .data = &sdm670_data }, { .compatible = "qcom,sdm845-mdss", .data = &sdm845_data }, { .compatible = "qcom,sc7180-mdss", .data = &sc7180_data },
Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. Signed-off-by: Mahadevan <quic_mahap@quicinc.com> --- [v2] - Update commit message. [Dmitry] - Reorder compatible string of MDSS based on alphabetical order. [Dmitry] - add reg_bus_bw in msm_mdss_data. [Dmitry] --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++ 1 file changed, 11 insertions(+)