| Message ID | ZvBNLRc8xnAoGvoc@Emma |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: usb: add missing compatible arraylist | expand |
On 22/09/2024 20:00, Karan Sanghavi wrote: > Added the vice versa order for compatible property in the yaml file so > that the dtb can parse for the order mentioned in the dts file > k3-am642-sk.dts for ti,j721e-usb.yaml k3-am642-sk.dts does not introduce any nodes with the said compatibles. "ti,am64-usb" compatible is introduced by k3-am642-main.dtsi. There is only one compatible introduced so there is nothing to do about order here. i.e. usbss0: cdns-usb@f900000 { compatible = "ti,am64-usb"; reg = <0x00 0xf900000 0x00 0x100>; What is the functional problem you are facing? Maybe then someone can point you in the right direction. > > This is highly ambiguous to me as where exactly the changes needs to be > added is it in the dts file or is the yaml where we have to reverse the > order already mentioned or do we have to add the another order as I have > done ? > > Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com> > --- > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > index 95ff9791baea..822653217c43 100644 > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > @@ -17,6 +17,9 @@ properties: > - items: > - const: ti,j721e-usb > - const: ti,am64-usb > + - items: > + - const: ti,am64-usb > + - const: ti,j721e-usb > > reg: > maxItems: 1
diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml index 95ff9791baea..822653217c43 100644 --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml @@ -17,6 +17,9 @@ properties: - items: - const: ti,j721e-usb - const: ti,am64-usb + - items: + - const: ti,am64-usb + - const: ti,j721e-usb reg: maxItems: 1
Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml This is highly ambiguous to me as where exactly the changes needs to be added is it in the dts file or is the yaml where we have to reverse the order already mentioned or do we have to add the another order as I have done ? Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com> --- Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++ 1 file changed, 3 insertions(+)