[v2,10/11] i2c: isch: Prefer to use octal permission

Message ID	20240916120237.1385982-11-andriy.shevchenko@linux.intel.com
State	New
Headers	show Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95AAE1598EE; Mon, 16 Sep 2024 12:02:55 +0000 (UTC) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andi Shyti <andi.shyti@kernel.org>, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jean Delvare <jdelvare@suse.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v2 10/11] i2c: isch: Prefer to use octal permission Date: Mon, 16 Sep 2024 15:01:37 +0300 Message-ID: <20240916120237.1385982-11-andriy.shevchenko@linux.intel.com> In-Reply-To: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com> References: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	i2c: isch: Put the driver into shape \| expand [v2,00/11] i2c: isch: Put the driver into shape [v2,01/11] i2c: isch: Pass pointer to struct i2c_adapter down [v2,02/11] i2c: isch: Use string_choices API instead of ternary operator [v2,03/11] i2c: isch: Switch to memory mapped IO accessors [v2,04/11] i2c: isch: Use custom private data structure [v2,05/11] i2c: isch: switch i2c registration to devm functions [v2,06/11] i2c: isch: Utilize temporary variable to hold device pointer [v2,07/11] i2c: isch: Use read_poll_timeout() [v2,08/11] i2c: isch: Unify the name of the variable to hold an error code [v2,09/11] i2c: isch: Don't use "proxy" headers [v2,10/11] i2c: isch: Prefer to use octal permission [v2,11/11] i2c: isch: Convert to kernel-doc

Message ID

20240916120237.1385982-11-andriy.shevchenko@linux.intel.com

State

New

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 10/11] i2c: isch: Prefer to use octal permission
Date: Mon, 16 Sep 2024 15:01:37 +0300
Message-ID: <20240916120237.1385982-11-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com>
References: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

i2c: isch: Put the driver into shape | expand

Commit Message

Andy Shevchenko Sept. 16, 2024, 12:01 p.m. UTC

Octal permissions are preferred over the symbolics ones
for readbility. This ceases warning message pointed by checkpatch.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-isch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 1a18a276a857..b2857e8e1c58 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -49,7 +49,7 @@  struct sch_i2c {
 };
 
 static int backbone_speed = 33000; /* backbone speed in kHz */
-module_param(backbone_speed, int, S_IRUSR | S_IWUSR);
+module_param(backbone_speed, int, 0600);
 MODULE_PARM_DESC(backbone_speed, "Backbone speed in kHz, (default = 33000)");
 
 static inline u8 sch_io_rd8(struct sch_i2c *priv, unsigned int offset)

[v2,10/11] i2c: isch: Prefer to use octal permission

Commit Message

Patch