diff mbox series

[v2] USB: serial: pl2303: account for deficits of clones

Message ID ecfefb25-7ce9-4a74-9708-f08d51d03ec1@siemens.com
State New
Headers show
Series [v2] USB: serial: pl2303: account for deficits of clones | expand

Commit Message

Jan Kiszka Sept. 12, 2024, 7:05 a.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

There are apparently incomplete clones of the HXD type chip in use.
Those return -EPIPE on GET_LINE_REQUEST and BREAK_REQUEST. Avoid
flooding the kernel log with those errors. Detect them during startup
and then use the line_settings cache instead of GET_LINE_REQUEST. Signal
missing break support via -ENOTTY.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Changes in v2:
 - probe for clone and avoid unsupported requests further on

 drivers/usb/serial/pl2303.c | 47 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

Comments

Michał Pecio Sept. 12, 2024, 8:26 a.m. UTC | #1 
Hi,

Wouldn't it be simpler to make this a quirk rather than a separate type?

Such approach has the added benefit of being easily adaptable to similar
half-baked clones claiming to be other types. AFAIS "pl2303" is about as
generic a name as "8051" these days, so I would prepare for the worst...

Regards,
Michal
diff mbox series

Patch

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index d93f5d584557..a61ae0d0c4ac 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -181,6 +181,7 @@  enum pl2303_type {
 	TYPE_TA,
 	TYPE_TB,
 	TYPE_HXD,
+	TYPE_HXD_CLONE,
 	TYPE_HXN,
 	TYPE_COUNT
 };
@@ -192,6 +193,7 @@  struct pl2303_type_data {
 	unsigned int no_autoxonxoff:1;
 	unsigned int no_divisors:1;
 	unsigned int alt_divisors:1;
+	unsigned int no_break_getline:1;
 };
 
 struct pl2303_serial_private {
@@ -232,6 +234,11 @@  static const struct pl2303_type_data pl2303_type_data[TYPE_COUNT] = {
 		.name			= "HXD",
 		.max_baud_rate		= 12000000,
 	},
+	[TYPE_HXD_CLONE] = {
+		.name			= "HXD",
+		.max_baud_rate		= 12000000,
+		.no_break_getline	= true,
+	},
 	[TYPE_HXN] = {
 		.name			= "G",
 		.max_baud_rate		= 12000000,
@@ -466,6 +473,28 @@  static int pl2303_detect_type(struct usb_serial *serial)
 	return -ENODEV;
 }
 
+static bool pl2303_is_hxd_clone(struct usb_serial *serial)
+{
+	struct usb_device *udev = serial->dev;
+	unsigned char *buf;
+	int ret;
+
+	buf = kmalloc(7, GFP_KERNEL);
+	if (!buf) {
+		dev_err(&serial->interface->dev,
+			"could not check for clone type, not enough memory\n");
+		return false;
+	}
+
+	ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
+			      GET_LINE_REQUEST, GET_LINE_REQUEST_TYPE,
+			      0, 0, buf, 7, 100);
+
+	kfree(buf);
+
+	return ret == -EPIPE;
+}
+
 static int pl2303_startup(struct usb_serial *serial)
 {
 	struct pl2303_serial_private *spriv;
@@ -484,6 +513,9 @@  static int pl2303_startup(struct usb_serial *serial)
 	if (!spriv)
 		return -ENOMEM;
 
+	if (type == TYPE_HXD && pl2303_is_hxd_clone(serial))
+		type = TYPE_HXD_CLONE;
+
 	spriv->type = &pl2303_type_data[type];
 	spriv->quirks = (unsigned long)usb_get_serial_data(serial);
 	spriv->quirks |= spriv->type->quirks;
@@ -724,9 +756,18 @@  static void pl2303_encode_baud_rate(struct tty_struct *tty,
 static int pl2303_get_line_request(struct usb_serial_port *port,
 							unsigned char buf[7])
 {
-	struct usb_device *udev = port->serial->dev;
+	struct usb_serial *serial = port->serial;
+	struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
+	struct usb_device *udev = serial->dev;
 	int ret;
 
+	if (spriv->type->no_break_getline) {
+		struct pl2303_private *priv = usb_get_serial_port_data(port);
+
+		memcpy(buf, priv->line_settings, 7);
+		return 0;
+	}
+
 	ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
 				GET_LINE_REQUEST, GET_LINE_REQUEST_TYPE,
 				0, 0, buf, 7, 100);
@@ -1063,9 +1104,13 @@  static int pl2303_carrier_raised(struct usb_serial_port *port)
 static int pl2303_set_break(struct usb_serial_port *port, bool enable)
 {
 	struct usb_serial *serial = port->serial;
+	struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
 	u16 state;
 	int result;
 
+	if (spriv->type->no_break_getline)
+		return -ENOTTY;
+
 	if (enable)
 		state = BREAK_ON;
 	else