| Message ID | 20240912073921.453203-44-pierrick.bouvier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Use g_assert_not_reached instead of (g_)assert(0, false) | expand |
On 9/12/24 09:39, Pierrick Bouvier wrote: > This patch is part of a series that moves towards a consistent use of > g_assert_not_reached() rather than an ad hoc mix of different > assertion mechanisms. > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > hw/ppc/ppc.c | 1 - > hw/ppc/spapr_events.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index e6fa5580c01..fde46194122 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) > break; > default: > g_assert_not_reached(); > - return; > } > } > > diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c > index 38ac1cb7866..4dbf8e2e2ef 100644 > --- a/hw/ppc/spapr_events.c > +++ b/hw/ppc/spapr_events.c > @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, > * that don't support them > */ > g_assert_not_reached(); > - return; > } > > if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) {
On 9/12/24 00:39, Pierrick Bouvier wrote: > This patch is part of a series that moves towards a consistent use of > g_assert_not_reached() rather than an ad hoc mix of different > assertion mechanisms. > > Signed-off-by: Pierrick Bouvier<pierrick.bouvier@linaro.org> > --- > hw/ppc/ppc.c | 1 - > hw/ppc/spapr_events.c | 1 - > 2 files changed, 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index e6fa5580c01..fde46194122 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) break; default: g_assert_not_reached(); - return; } } diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 38ac1cb7866..4dbf8e2e2ef 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, * that don't support them */ g_assert_not_reached(); - return; } if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) {
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-)