diff mbox series

ASoC: tas2781: fix to save the dsp bin file name into the correct array in case name_prefix is not NULL

Message ID 20240907001540.944-1-shenghao-ding@ti.com
State Accepted
Commit af5e317175858603f950e51fe6377027fdd6eb79
Headers show
Series ASoC: tas2781: fix to save the dsp bin file name into the correct array in case name_prefix is not NULL | expand

Commit Message

Shenghao Ding Sept. 7, 2024, 12:15 a.m. UTC
fix to save the dsp bin file name into the correct array, coef_binaryname,
instead of rca_binaryname, in case name_prefix is not NULL.

Fixes: 55f0a1fa6ea4 ("ASoC: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
 sound/soc/codecs/tas2781-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Sept. 9, 2024, 10:13 a.m. UTC | #1
On Sat, Sep 07, 2024 at 08:15:37AM +0800, Shenghao Ding wrote:
> Remove unnecessary line feed for tasdevice_dsp_create_ctrls,
> and remove two unnecessary spaces in tas2563_digital_gain_get
> and tas2563_digital_gain_put.

FWIW, we refer to the functions as func(). The above will be

Remove unnecessary line feed for tasdevice_dsp_create_ctrls(),
and remove two unnecessary spaces in tas2563_digital_gain_get()
and tas2563_digital_gain_put().
Mark Brown Sept. 9, 2024, 3:25 p.m. UTC | #2
On Sat, 07 Sep 2024 08:15:36 +0800, Shenghao Ding wrote:
> fix to save the dsp bin file name into the correct array, coef_binaryname,
> instead of rca_binaryname, in case name_prefix is not NULL.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tas2781: fix to save the dsp bin file name into the correct array in case name_prefix is not NULL
      commit: af5e317175858603f950e51fe6377027fdd6eb79
[1/1] ASoc: tas2781: Remove unnecessary line feed and space
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 59fcce7fef7b..3bc10d615fd3 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -498,7 +498,7 @@  static void tasdevice_fw_ready(const struct firmware *fmw,
 	 */
 	tas_priv->fw_state = TASDEVICE_RCA_FW_OK;
 	if (tas_priv->name_prefix)
-		scnprintf(tas_priv->rca_binaryname, 64, "%s-%s_coef.bin",
+		scnprintf(tas_priv->coef_binaryname, 64, "%s-%s_coef.bin",
 			tas_priv->name_prefix, tas_priv->dev_name);
 	else
 		scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin",