| Message ID | CAAgBjM=h6mDnppMVQyCU21hufHYbTHFwFJxBkyQN8bZdWYPRgg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: > Hi, > As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi. > OK to commit ? You might check if Aldy's change to the uninit code helps your case (approved earlier today, so hopefully in the tree very soon). I quickly scanned the BZ. There's some overlap, but it might be too complex for Aldy's enhancements to catch. jeff
On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote: > On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: >> >> Hi, >> As discussed in PR, this patch marks the test-case to xfail on >> arm-none-eabi. >> OK to commit ? > > You might check if Aldy's change to the uninit code helps your case > (approved earlier today, so hopefully in the tree very soon). I quickly > scanned the BZ. There's some overlap, but it might be too complex for > Aldy's enhancements to catch. Hi Jeff, I tried Aldy's patch [1], but it didn't catch the case in PR78319. [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html Thanks, Prathamesh > > jeff
On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote: > > On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: > >> > >> Hi, > >> As discussed in PR, this patch marks the test-case to xfail on > >> arm-none-eabi. > >> OK to commit ? > > > > You might check if Aldy's change to the uninit code helps your case > > (approved earlier today, so hopefully in the tree very soon). I quickly > > scanned the BZ. There's some overlap, but it might be too complex for > > Aldy's enhancements to catch. > Hi Jeff, > I tried Aldy's patch [1], but it didn't catch the case in PR78319. > > [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html XFAILing is ok. Richard. > Thanks, > Prathamesh > > > > jeff > > -- Richard Biener <rguenther@suse.de> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
On 11/17/2016 01:52 AM, Richard Biener wrote: > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > >> On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote: >>> On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: >>>> >>>> Hi, >>>> As discussed in PR, this patch marks the test-case to xfail on >>>> arm-none-eabi. >>>> OK to commit ? >>> >>> You might check if Aldy's change to the uninit code helps your case >>> (approved earlier today, so hopefully in the tree very soon). I quickly >>> scanned the BZ. There's some overlap, but it might be too complex for >>> Aldy's enhancements to catch. >> Hi Jeff, >> I tried Aldy's patch [1], but it didn't catch the case in PR78319. >> >> [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html > > XFAILing is ok. Agreed. Thanks for checking Prathamesh. Jeff
diff --git a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c index 1b7c472..c45fba0 100644 --- a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c +++ b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c @@ -16,8 +16,9 @@ int foo (int n, int l, int m, int r) if (m) g++; else bar(); + /* marking this test as xfail on arm-none-eabi, see PR78319. */ if ( n || m || r || l) - blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ + blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail arm-none-eabi } } */ if ( n ) blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */