| Message ID | 20240905112508.160560-1-biju.das.jz@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: platform: rzg2l-cru: rzg2l-video: Fix the comment in rzg2l_cru_start_streaming_vq() | expand |
Hi Biju, Thank you for the patch. On Thu, Sep 05, 2024 at 12:25:05PM +0100, Biju Das wrote: > Replace "buffer." -> "buffer", for consistency with rest of the > comment blocks in rzg2l_cru_start_streaming_vq(). I usually go the other way around, sentences should end with a period. You can go either way as it's your driver. > Reported-by: Pavel Machek <pavel@denx.de> > Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > This patch have merge dependency on [1] > [1] https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.renesas.com/ > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index bbf4674f888d..d17e3eac4177 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count > goto assert_aresetn; > } > > - /* Allocate scratch buffer. */ > + /* Allocate scratch buffer */ > cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, > &cru->scratch_phys, GFP_KERNEL); > if (!cru->scratch) {
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index bbf4674f888d..d17e3eac4177 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count goto assert_aresetn; } - /* Allocate scratch buffer. */ + /* Allocate scratch buffer */ cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, &cru->scratch_phys, GFP_KERNEL); if (!cru->scratch) {
Replace "buffer." -> "buffer", for consistency with rest of the comment blocks in rzg2l_cru_start_streaming_vq(). Reported-by: Pavel Machek <pavel@denx.de> Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- This patch have merge dependency on [1] [1] https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.renesas.com/ --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)