| Message ID | 20240903014317.38858-1-tamim@fusetak.com |
|---|---|
| State | Accepted |
| Commit | 49e9cc315604972cc14868cb67831e3e8c3f1470 |
| Headers | show |
| Series | ACPI: resource: Skip IRQ override on Asus Vivobook Go E1404GAB | expand |
On 03.09.24 03:43, Tamim Khan wrote: > Like other Asus Vivobooks, the Asus Vivobook Go E1404GAB has a DSDT > that describes IRQ 1 as ActiveLow, while the kernel overrides to Edge_High. > This override prevents the internal keyboard from working. This patch fixes > this problem by adding this laptop to the table that prevents the kernel from > overriding the IRQ. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=219212 Thx for that. FWIW, I by chance noticed another such report about the E1404GA: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Ciao, Thorsten
On 05.09.24 11:51, Thorsten Leemhuis wrote: > On 03.09.24 03:43, Tamim Khan wrote: >> Like other Asus Vivobooks, the Asus Vivobook Go E1404GAB has a DSDT >> that describes IRQ 1 as ActiveLow, while the kernel overrides to Edge_High. >> This override prevents the internal keyboard from working. This patch fixes >> this problem by adding this laptop to the table that prevents the kernel from >> overriding the IRQ. >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219212 > > Thx for that. FWIW, I by chance noticed another such report about the > E1404GA: https://bugzilla.kernel.org/show_bug.cgi?id=219224 TWIMC, shortly after sending this mail I noticed there is another request for a quirk that was send to the list, bug afaics fall through the cracks. See here: https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/ It afaics add a X1704VAP: { /* Asus Vivobook X1704V */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"), }, }, Ciao, Thorsten
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index df5d5a554b38..c65c72c515e6 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -503,6 +503,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "B2502FBA"), }, }, + { + /* Asus Vivobook Go E1404GAB */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"), + }, + }, { /* Asus Vivobook E1504GA */ .matches = {
Like other Asus Vivobooks, the Asus Vivobook Go E1404GAB has a DSDT that describes IRQ 1 as ActiveLow, while the kernel overrides to Edge_High. This override prevents the internal keyboard from working. This patch fixes this problem by adding this laptop to the table that prevents the kernel from overriding the IRQ. Link: https://bugzilla.kernel.org/show_bug.cgi?id=219212 Signed-off-by: Tamim Khan <tamim@fusetak.com> --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+)