diff mbox series

[v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property

Message ID 871q1zkmrc.wl-kuninori.morimoto.gx@renesas.com
State New
Headers show
Series [v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property | expand

Commit Message

Kuninori Morimoto Sept. 4, 2024, 11:44 p.m. UTC
At least if rsnd is using DPCM connection with Audio-Graph-Card2,
fw_devlink might doesn't have enough information to break the cycle
(Same problem might occur with Multi-CPU/Codec or Codec2Codec).
In such case, rsnd driver will not be probed.
Add post-init-providers support to break the link cycle.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- remove basic description/type
	- add detail description
	- update git-log

 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rob Herring (Arm) Sept. 9, 2024, 2:22 p.m. UTC | #1
On Wed, Sep 04, 2024 at 11:44:08PM +0000, Kuninori Morimoto wrote:
> At least if rsnd is using DPCM connection with Audio-Graph-Card2,
> fw_devlink might doesn't have enough information to break the cycle
> (Same problem might occur with Multi-CPU/Codec or Codec2Codec).
> In such case, rsnd driver will not be probed.
> Add post-init-providers support to break the link cycle.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> 	- remove basic description/type
> 	- add detail description
> 	- update git-log
> 
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 07ec6247d9def..458877ce4aa42 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,6 +112,13 @@ properties:
>      description: List of necessary clock names.
>      # details are defined below
>  
> +  post-init-providers:
> +    description: |

Don't need '|' if there's no formatting.

> +      At least if rsnd is using DPCM connection with Audio-Graph-Card2, fw_devlink might doesn't
> +      have enough information to break the cycle. rsnd driver will not be probed in such case.

Wrap lines at 80, not 100 unless there's good reason to extend them.

> +      Add post-init-providers property to indicate which link in the cycle to break.

That describes every use of post-init-providers. Drop.

> +      Same problem might occur with Multi-CPU/Codec or Codec2Codec.
> +
>    # ports is below
>    port:
>      $ref: audio-graph-port.yaml#/definitions/port-base
> -- 
> 2.43.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
index 07ec6247d9def..458877ce4aa42 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
@@ -112,6 +112,13 @@  properties:
     description: List of necessary clock names.
     # details are defined below
 
+  post-init-providers:
+    description: |
+      At least if rsnd is using DPCM connection with Audio-Graph-Card2, fw_devlink might doesn't
+      have enough information to break the cycle. rsnd driver will not be probed in such case.
+      Add post-init-providers property to indicate which link in the cycle to break.
+      Same problem might occur with Multi-CPU/Codec or Codec2Codec.
+
   # ports is below
   port:
     $ref: audio-graph-port.yaml#/definitions/port-base