wifi: ath10k: add USB device ID for Atheros QCA9377-7

Add USB device ID for modules based on Atheros QCA9377-7 chipset like
8devices BLUE bean or SparkLAN WUBQ-159ACN.

Tested-on: QCA9377 hw1.1 USB
Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
---
 drivers/net/wireless/ath/ath10k/usb.c | 1 +
 1 file changed, 1 insertion(+)

On 8/30/2024 4:28 AM, Tomas Paukrt wrote:
> Add USB device ID for modules based on Atheros QCA9377-7 chipset like
> 8devices BLUE bean or SparkLAN WUBQ-159ACN.
> 
> Tested-on: QCA9377 hw1.1 USB
Since Tested-on is not an official upstream tag there should be a blank line
between it and the official tags.

Also the Tested-on tag should include the firmware version information as well.

See
<https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag>

> Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
> ---
>  drivers/net/wireless/ath/ath10k/usb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/ath/ath10k/usb.c
> index 3b51b7f..60441ff 100644
> --- a/drivers/net/wireless/ath/ath10k/usb.c
> +++ b/drivers/net/wireless/ath/ath10k/usb.c
> @@ -1106,6 +1106,7 @@ static int ath10k_usb_pm_resume(struct usb_interface *interface)
>  
>  /* table of devices that work with this driver */
>  static struct usb_device_id ath10k_usb_ids[] = {
> +	{USB_DEVICE(0x0cf3, 0x9378)}, /* Atheros QCA9377-7 */
>  	{USB_DEVICE(0x13b1, 0x0042)}, /* Linksys WUSB6100M */
>  	{ /* Terminating entry */ },
>  };

> Also the Tested-on tag should include the firmware version information as well.

Hi Jeff,

I tested it with manually converted firmware from https://github.com/8devices/qcacld-2.0/tree/CNSS.LEA.NRT_3.0/firmware_bin/usb which does not include any explicit version.

What version should I write in the Tested-on tag in this case?

Best regards

Tomas

On 9/4/2024 11:28 AM, Tomas Paukrt wrote:
>> Also the Tested-on tag should include the firmware version information as well.
> 
> Hi Jeff,
> 
> I tested it with manually converted firmware from https://github.com/8devices/qcacld-2.0/tree/CNSS.LEA.NRT_3.0/firmware_bin/usb which does not include any explicit version.
> 
> What version should I write in the Tested-on tag in this case?

Ah, my good friend qcacld-2.0.

I'd expect to see something written to kmsg, but not sure it is there for USB.

for QMI there is: 
		ath10k_info(ar, "qmi fw_version 0x%x fw_build_timestamp %s fw_build_id %s",
			    qmi->fw_version, qmi->fw_build_timestamp, qmi->fw_build_id);

but looking at past ath10k USB changes I only see:
    Tested-on: QCA9377 hw1.0 USB 1.0.0.299

So I guess what you have is OK since this just allows you to be probed anyway
so that is actually independent of firmware version.

> Ah, my good friend qcacld-2.0.
>
> I'd expect to see something written to kmsg, but not sure it is there for USB.
>
> for QMI there is: 
> 		ath10k_info(ar, "qmi fw_version 0x%x fw_build_timestamp %s fw_build_id %s",
> 			    qmi->fw_version, qmi->fw_build_timestamp, qmi->fw_build_id);

> but looking at past ath10k USB changes I only see:
>     Tested-on: QCA9377 hw1.0 USB 1.0.0.299

> So I guess what you have is OK since this just allows you to be probed anyway
> so that is actually independent of firmware version.

I cross-compiled the qcacld-2.0 driver and it printed this:

Host SW:4.5.25.50, FW:0.0.0.111, HW:QCA93x7_REV1_1

It looks like that 8devices is using their own firmware numbering.