diff mbox series

[v3,2/2] dt-bindings: mmc: atmel,sama5d2-sdhci: Add sama7d65 compatible

Message ID 20240830-atmel-sdhci-v3-2-7c97a0872af4@microchip.com
State Superseded
Headers show
Series Update sdhci-atmel dt-binding documentation | expand

Commit Message

Dharma Balasubiramani Aug. 30, 2024, 2:51 p.m. UTC
Add mmc binding documentation for sama7d65.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Aug. 31, 2024, 6:20 a.m. UTC | #1
On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
> Add mmc binding documentation for sama7d65.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>  Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Where is any user of this? Why are you adding bindings without users?

Best regards,
Krzysztof
Dharma Balasubiramani Aug. 31, 2024, 7:51 a.m. UTC | #2
Hi Krzysztof,

On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>> Add mmc binding documentation for sama7d65.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> ---
>>   Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> 
> Where is any user of this? Why are you adding bindings without users?

We will upstream the sama7d65 board dts files soon, hence adding support 
for it before hand in bindings.

> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Aug. 31, 2024, 1:41 p.m. UTC | #3
On 31/08/2024 09:51, Dharma.B@microchip.com wrote:
> Hi Krzysztof,
> 
> On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>>> Add mmc binding documentation for sama7d65.
>>>
>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>
>> Where is any user of this? Why are you adding bindings without users?
> 
> We will upstream the sama7d65 board dts files soon, hence adding support 
> for it before hand in bindings.
> 

Not soon. Two of your other postings are clearly wrongly split, so I
don't trust this one either.

Post everything. Your drivers with their bindings. Your DTS goes with
board bindings, in separate patchset (one!) with lore link to the driver
bindings so we can verify it.

Best regards,
Krzysztof
Dharma Balasubiramani Sept. 2, 2024, 10:40 a.m. UTC | #4
On 31/08/24 7:11 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 31/08/2024 09:51, Dharma.B@microchip.com wrote:
>> Hi Krzysztof,
>>
>> On 31/08/24 11:50 am, Krzysztof Kozlowski wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On Fri, Aug 30, 2024 at 08:21:21PM +0530, Dharma Balasubiramani wrote:
>>>> Add mmc binding documentation for sama7d65.
>>>>
>>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>
>>> Where is any user of this? Why are you adding bindings without users?
>>
>> We will upstream the sama7d65 board dts files soon, hence adding support
>> for it before hand in bindings.
>>
> 
> Not soon. Two of your other postings are clearly wrongly split, so I
> don't trust this one either.
> 
> Post everything. Your drivers with their bindings. Your DTS goes with
> board bindings, in separate patchset (one!) with lore link to the driver
> bindings so we can verify it.

Okay, I will drop this now, I will just send the conversion from text to 
json in the next revision of this patch.

Will send it along with the dts as you suggest.
Thanks.

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
index ba4786328833..a7c0ce201a5c 100644
--- a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
@@ -25,6 +25,11 @@  properties:
           - enum:
               - microchip,sama7g5-sdhci
           - const: microchip,sam9x60-sdhci
+      - items:
+          - enum:
+              - microchip,sama7d65-sdhci
+          - const: microchip,sama7g5-sdhci
+          - const: microchip,sam9x60-sdhci
 
   reg:
     maxItems: 1