| Message ID | 20240830011752.603433-2-lizetao1@huawei.com |
|---|---|
| State | Accepted |
| Commit | 7adc7193537470839ec66ecbdb54f4dc9092e6f6 |
| Headers | show |
| Series | media: atomisp: use clamp() instead of min(max()) | expand |
Hi, On 8/30/24 3:17 AM, Li Zetao wrote: > When it needs to get a value within a certain interval, using clamp() > makes the code easier to understand than min(max()). > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Thank you for your 2 patch(es). I have merged this/these in my media-atomisp branch: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp And this/these will be included in my next pull-request to Mauro (to media subsystem maintainer) Regards, Hans > --- > .../media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c > index e4fc90f88e24..55d102b479ac 100644 > --- a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c > +++ b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c > @@ -276,7 +276,7 @@ ia_css_eed1_8_encode( > for (i = 0; i < (IA_CSS_NUMBER_OF_DEW_ENHANCE_SEGMENTS - 1); i++) { > min_exp = max(min_exp, from->dew_enhance_seg_exp[i]); > } > - to->e_dew_enh_asr = 13 - min(max(min_exp, 0), 13); > + to->e_dew_enh_asr = 13 - clamp(min_exp, 0, 13); > > to->dedgew_max = from->dedgew_max; > }
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c index e4fc90f88e24..55d102b479ac 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c @@ -276,7 +276,7 @@ ia_css_eed1_8_encode( for (i = 0; i < (IA_CSS_NUMBER_OF_DEW_ENHANCE_SEGMENTS - 1); i++) { min_exp = max(min_exp, from->dew_enhance_seg_exp[i]); } - to->e_dew_enh_asr = 13 - min(max(min_exp, 0), 13); + to->e_dew_enh_asr = 13 - clamp(min_exp, 0, 13); to->dedgew_max = from->dedgew_max; }
When it needs to get a value within a certain interval, using clamp() makes the code easier to understand than min(max()). Signed-off-by: Li Zetao <lizetao1@huawei.com> --- .../media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)