| Message ID | 20161115193133.GL3145@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Nov 15, 2016 at 11:31 AM, Jonathan Wakely <jwakely@redhat.com> wrote: > On 15/11/16 12:08 +0000, Jonathan Wakely wrote: >> >> On 12/11/16 12:11 -0800, Tim Shen wrote: >>> >>> At Issaquah we decided to remove the supports above. >> >> >> OK with a suitable ChangeLog, thanks. > > > I've adjusted your ChangeLog entry to fit under 80 columns with TAB > set to 8 spaces. I've also adjusted the pretty printer test that was > using variant<string_view&>. Thanks! This is how tabstop=2 people have a different view of world from the rest of us. :) And I keep forgetting running the whole testsuite. Sorry! > > Tested x86_64-linux, committed to trunk. > -- Regards, Tim Shen
commit ab5b0b5d8618cd03e4d21a37b782d2726361bde2
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 15 19:21:02 2016 +0000
Adjust pretty printer test for variant<T&>
* testsuite/libstdc++-prettyprinters/cxx17.cc: Adjust test for
variant<T&>.
diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx17.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx17.cc
index bc9b26a..96be8c7 100644
--- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx17.cc
+++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx17.cc
@@ -86,8 +86,8 @@ main()
// { dg-final { note-test v3 {std::variant<float, int, std::string_view> [index 1] = {3}} } }
variant<float, int, string_view> v4{ str };
// { dg-final { note-test v4 {std::variant<float, int, std::string_view> [index 2] = {"string"}} } }
- variant<string_view&> vref{str};
-// { dg-final { note-test vref {std::variant<std::basic_string_view<char, std::char_traits<char> > &> [index 0] = {"string"}} } }
+ variant<string_view> vref{str};
+// { dg-final { note-test vref {std::variant<std::string_view> [index 0] = {"string"}} } }
map<int, string_view> m{ {1, "one"} };
map<int, string_view>::node_type n0;