| Message ID | 20240828120502.1439-1-quic_mapa@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: ufs: qcom: update MODE_MAX cfg_bw value | expand |
On 8/28/24 8:05 AM, Manish Pandey wrote:
> update cfg_bw value for MODE_MAX for Qualcomm SoC.
A patch description should not only explain what has been changed but
also why.
Thanks,
Bart.
On Wed, Aug 28, 2024 at 05:35:02PM +0530, Manish Pandey wrote: > update cfg_bw value for MODE_MAX for Qualcomm SoC. > As Bart said, please do not send patches with these vague descriptions. They provide no info whatsoever to the community on why this patch is needed. There should be a valid justification to convince the community to accept your patch. If you are sending a series, this same comment applies to all the patches. - Mani > Signed-off-by: Manish Pandey <quic_mapa@quicinc.com> > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index c87fdc849c62..ecdfff2456e3 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table { > [MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 }, > [MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 }, > [MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 }, > - [MODE_MAX][0][0] = { 7643136, 307200 }, > + [MODE_MAX][0][0] = { 7643136, 819200 }, > }; > > static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host); > -- > 2.17.1 >
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index c87fdc849c62..ecdfff2456e3 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table { [MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 }, [MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 }, [MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 }, - [MODE_MAX][0][0] = { 7643136, 307200 }, + [MODE_MAX][0][0] = { 7643136, 819200 }, }; static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
update cfg_bw value for MODE_MAX for Qualcomm SoC. Signed-off-by: Manish Pandey <quic_mapa@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)