| Message ID | 20240826133237.134604-1-bastien.curutchet@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | leds: pca9532: Remove irrelevant error message | expand |
On Mon, 26 Aug 2024 15:32:37 +0200, Bastien Curutchet wrote: > The update_hw_blink() function prints an error message when hardware is > not able to handle a blink configuration on its own. IMHO, this isn't a > 'real' error since the software fallback is used afterwards. > > Remove the error messages to avoid flooding the logs with unnecessary > messages. > > [...] Applied, thanks! [1/1] leds: pca9532: Remove irrelevant error message commit: 2aad93b6de0d874038d3d7958be05011284cd6b9 -- Lee Jones [李琼斯]
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 9f3fac66a11c..bcc3063bd441 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -215,8 +215,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, if (other->state == PCA9532_PWM1) { if (other->ldev.blink_delay_on != delay_on || other->ldev.blink_delay_off != delay_off) { - dev_err(&led->client->dev, - "HW can handle only one blink configuration at a time\n"); + /* HW can handle only one blink configuration at a time */ return -EINVAL; } } @@ -224,7 +223,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000; if (psc > U8_MAX) { - dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n"); + /* Blink period too long to be handled by hardware */ return -EINVAL; }
The update_hw_blink() function prints an error message when hardware is not able to handle a blink configuration on its own. IMHO, this isn't a 'real' error since the software fallback is used afterwards. Remove the error messages to avoid flooding the logs with unnecessary messages. Cc: stable@vger.kernel.org Fixes: 48ca7f302cfc ("leds: pca9532: Use PWM1 for hardware blinking") Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com> --- drivers/leds/leds-pca9532.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)