| Message ID | 3112cb1127580bf714f50a199b4ec9e998322202.1724846454.git.jerome.forissier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Miscellaneous fixes | expand |
On Wed, 28 Aug 2024 at 06:12, Jerome Forissier <jerome.forissier@linaro.org> wrote: > > FTGMAC100 enables drivers/net/ftgmac100.c which uses > PHY_INTERFACE_MODE_NCSI, which is defined only when PHY_NCSI is enabled. > Therefore FTGMAC100 depends on PHY_NCSI. However adding such a > dependency causes a "recursive dependency detected!" message, so > add a dependency on NET instead (PHY_NCSI depends on NET). > All in all, either the stack is NET and FTGMAC100 can be enabled, > or it is NET_LWIP (or NO_NET) and it cannot. > > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > --- > drivers/net/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass <sjg@chromium.org> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 69ae7c0750..3382e533f4 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -461,6 +461,7 @@ config FTMAC100 > config FTGMAC100 > bool "Ftgmac100 Ethernet Support" > select PHYLIB > + depends on NET > help > This driver supports the Faraday's FTGMAC100 Gigabit SoC > Ethernet controller that can be found on Aspeed SoCs (which > -- > 2.40.1 >
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 69ae7c0750..3382e533f4 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -461,6 +461,7 @@ config FTMAC100 config FTGMAC100 bool "Ftgmac100 Ethernet Support" select PHYLIB + depends on NET help This driver supports the Faraday's FTGMAC100 Gigabit SoC Ethernet controller that can be found on Aspeed SoCs (which
FTGMAC100 enables drivers/net/ftgmac100.c which uses PHY_INTERFACE_MODE_NCSI, which is defined only when PHY_NCSI is enabled. Therefore FTGMAC100 depends on PHY_NCSI. However adding such a dependency causes a "recursive dependency detected!" message, so add a dependency on NET instead (PHY_NCSI depends on NET). All in all, either the stack is NET and FTGMAC100 can be enabled, or it is NET_LWIP (or NO_NET) and it cannot. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+)