| Message ID | 20240822152801.602318-10-claudiu.beznea.uj@bp.renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add initial USB support for the Renesas RZ/G3S SoC | expand |
Hi Claudiu, On Thu, Aug 22, 2024 at 5:28 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > The USBHS IP block on RZ/G3S SoC is identitcal to the one found on the > RZ/G2L device. Document the RZ/G3S USBHS IP block. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > @@ -26,6 +26,7 @@ properties: > - renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five > - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} > - renesas,usbhs-r9a07g054 # RZ/V2L > + - renesas,usbhs-r9a08g045 # RZ/G3S > - const: renesas,rzg2l-usbhs > > - items: So we do have new users of the HS-USB block! If you do have a need for renesas,enable-gpios, it may be a good idea to proceed as per the discussion in "[PATCH 1/2] dt-bindings: usb: renesas,usbhs: Deprecate renesas,enable-gpio" (https://lore.kernel.org/all/20241002213652.GA1330004-robh@kernel.org/). Gr{oetje,eeting}s, Geert
Hi, Geert, On 08.10.2024 17:51, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Thu, Aug 22, 2024 at 5:28 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> The USBHS IP block on RZ/G3S SoC is identitcal to the one found on the >> RZ/G2L device. Document the RZ/G3S USBHS IP block. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml >> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml >> @@ -26,6 +26,7 @@ properties: >> - renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five >> - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} >> - renesas,usbhs-r9a07g054 # RZ/V2L >> + - renesas,usbhs-r9a08g045 # RZ/G3S >> - const: renesas,rzg2l-usbhs >> >> - items: > > So we do have new users of the HS-USB block! > If you do have a need for renesas,enable-gpios, it may be a good idea > to proceed as per the discussion in "[PATCH 1/2] dt-bindings: usb: > renesas,usbhs: Deprecate renesas,enable-gpio" > (https://lore.kernel.org/all/20241002213652.GA1330004-robh@kernel.org/). Thank you for letting me know. As of my current investigation there is no need for this property. I'll keep it in mind, anyway. Thank you, Claudiu Beznea > > Gr{oetje,eeting}s, > > Geert >
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml index c63db3ebd07b..0f84cba872ce 100644 --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml @@ -26,6 +26,7 @@ properties: - renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} - renesas,usbhs-r9a07g054 # RZ/V2L + - renesas,usbhs-r9a08g045 # RZ/G3S - const: renesas,rzg2l-usbhs - items: @@ -126,6 +127,7 @@ allOf: - renesas,usbhs-r9a07g043 - renesas,usbhs-r9a07g044 - renesas,usbhs-r9a07g054 + - renesas,usbhs-r9a08g045 then: properties: interrupts: