diff mbox series

pm-graph: ignore sleepgraph.py artifacts

Message ID 20240825095353.7578-1-0xff07@gmail.com
State Accepted
Commit dd7c445beb7baf0ed071aba94341857b07fde69b
Headers show
Series pm-graph: ignore sleepgraph.py artifacts | expand

Commit Message

Yo-Jung (Leo) Lin Aug. 25, 2024, 9:53 a.m. UTC
By default, sleepgraph.py creates suspend-{date}-{time} directories
to store artifacts, or suspend-{date}-{time}-xN if the --multi option
is used. Ignore those directories by adding a .gitignore file.

Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
---
 tools/power/pm-graph/.gitignore | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 tools/power/pm-graph/.gitignore

Comments

Todd Brandt Aug. 26, 2024, 8:30 p.m. UTC | #1
On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> By default, sleepgraph.py creates suspend-{date}-{time} directories
> to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> is used. Ignore those directories by adding a .gitignore file.
> 
> Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> ---
>  tools/power/pm-graph/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/power/pm-graph/.gitignore
> 
> diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> graph/.gitignore
> new file mode 100644
> index 000000000000..37762a8a06d6
> --- /dev/null
> +++ b/tools/power/pm-graph/.gitignore
> @@ -0,0 +1,3 @@
> +# sleepgraph.py artifacts
> +suspend-[0-9]*-[0-9]*
> +suspend-[0-9]*-[0-9]*-x[0-9]*
This seems fine. If you run the tool inside the tools/power/pm-graph
folder I can see how it would be annoying to have all those output
directories show up in git status.

Signed-off-by: Todd Brandt <todd.e.brandt@linux.intel.com>
Todd Brandt Aug. 26, 2024, 8:49 p.m. UTC | #2
On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> By default, sleepgraph.py creates suspend-{date}-{time} directories
> to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> is used. Ignore those directories by adding a .gitignore file.
> 
> Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> ---
>  tools/power/pm-graph/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/power/pm-graph/.gitignore
> 
> diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> graph/.gitignore
> new file mode 100644
> index 000000000000..37762a8a06d6
> --- /dev/null
> +++ b/tools/power/pm-graph/.gitignore
> @@ -0,0 +1,3 @@
> +# sleepgraph.py artifacts
> +suspend-[0-9]*-[0-9]*
> +suspend-[0-9]*-[0-9]*-x[0-9]*
This seems fine. If you run the tool inside the tools/power/pm-graph
folder I can see how it would be annoying to have all those output
directories show up in git status. (re-send with Acked-by)

Acked-by: Todd Brandt <todd.e.brandt@linux.intel.com>
Rafael J. Wysocki Sept. 4, 2024, 12:33 p.m. UTC | #3
On Mon, Aug 26, 2024 at 10:49 PM Todd Brandt
<todd.e.brandt@linux.intel.com> wrote:
>
> On Sun, 2024-08-25 at 17:53 +0800, Yo-Jung (Leo) Lin wrote:
> > By default, sleepgraph.py creates suspend-{date}-{time} directories
> > to store artifacts, or suspend-{date}-{time}-xN if the --multi option
> > is used. Ignore those directories by adding a .gitignore file.
> >
> > Signed-off-by: Yo-Jung (Leo) Lin <0xff07@gmail.com>
> > ---
> >  tools/power/pm-graph/.gitignore | 3 +++
> >  1 file changed, 3 insertions(+)
> >  create mode 100644 tools/power/pm-graph/.gitignore
> >
> > diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-
> > graph/.gitignore
> > new file mode 100644
> > index 000000000000..37762a8a06d6
> > --- /dev/null
> > +++ b/tools/power/pm-graph/.gitignore
> > @@ -0,0 +1,3 @@
> > +# sleepgraph.py artifacts
> > +suspend-[0-9]*-[0-9]*
> > +suspend-[0-9]*-[0-9]*-x[0-9]*
> This seems fine. If you run the tool inside the tools/power/pm-graph
> folder I can see how it would be annoying to have all those output
> directories show up in git status. (re-send with Acked-by)
>
> Acked-by: Todd Brandt <todd.e.brandt@linux.intel.com>

Applied as 6.12 material, thanks!
diff mbox series

Patch

diff --git a/tools/power/pm-graph/.gitignore b/tools/power/pm-graph/.gitignore
new file mode 100644
index 000000000000..37762a8a06d6
--- /dev/null
+++ b/tools/power/pm-graph/.gitignore
@@ -0,0 +1,3 @@ 
+# sleepgraph.py artifacts
+suspend-[0-9]*-[0-9]*
+suspend-[0-9]*-[0-9]*-x[0-9]*