| Message ID | 20240823034314.62305-3-ye.zhang@rock-chips.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] gpio: rockchip: release reference to device node | expand |
Am Freitag, 23. August 2024, 05:43:05 CEST schrieb Ye Zhang: > Added a call to of_node_put(pctlnp) in rockchip_gpio_probe to properly > release the reference to the device node, improving memory management > and preventing potential leaks. > > Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") > Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
在 2024/8/23 11:43, Ye Zhang 写道: > Added a call to of_node_put(pctlnp) in rockchip_gpio_probe to properly > release the reference to the device node, improving memory management > and preventing potential leaks. > > Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") > Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > drivers/gpio/gpio-rockchip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index 712258224eb3..5f60162baaeb 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -715,6 +715,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev) > return -ENODEV; > > pctldev = of_pinctrl_get(pctlnp); > + of_node_put(pctlnp); > if (!pctldev) > return -EPROBE_DEFER; >
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 712258224eb3..5f60162baaeb 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -715,6 +715,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev) return -ENODEV; pctldev = of_pinctrl_get(pctlnp); + of_node_put(pctlnp); if (!pctldev) return -EPROBE_DEFER;
Added a call to of_node_put(pctlnp) in rockchip_gpio_probe to properly release the reference to the device node, improving memory management and preventing potential leaks. Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio") Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com> --- drivers/gpio/gpio-rockchip.c | 1 + 1 file changed, 1 insertion(+)