| Message ID | 20240822020339.474715-1-link@vivo.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] leds: lp55xx: Use devm_clk_get_enabled() helpers | expand |
On Thu, 22 Aug 2024, Huan Yang wrote: > lp55xx lp55xx_is_extclk_used get, enable clk and > deinit_device disable and unprepare it. > > This can use a simplifies helper to cover. And no need to save clk > pointer, this can save a little memory. > > Signed-off-by: Huan Yang <link@vivo.com> > --- > v2 -> v3: remove unneccessary suggested tag. Sorry, what's this? > v1 -> v2: remove clk pointer from lp55xx_chip > > drivers/leds/leds-lp55xx-common.c | 15 ++------------- > drivers/leds/leds-lp55xx-common.h | 1 - > 2 files changed, 2 insertions(+), 14 deletions(-)
在 2024/8/22 21:50, Lee Jones 写道:
> Sorry, what's this?
A suggested-by remove, which Christophe JAILLET recommand me.
If v2 accepted, maybe you can ignore it.
diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 29e7142dca72..1bbe170a217b 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -965,24 +965,16 @@ EXPORT_SYMBOL_GPL(lp55xx_update_bits); bool lp55xx_is_extclk_used(struct lp55xx_chip *chip) { struct clk *clk; - int err; - clk = devm_clk_get(&chip->cl->dev, "32k_clk"); + clk = devm_clk_get_enabled(&chip->cl->dev, "32k_clk"); if (IS_ERR(clk)) goto use_internal_clk; - err = clk_prepare_enable(clk); - if (err) + if (clk_get_rate(clk) != LP55XX_CLK_32K) goto use_internal_clk; - if (clk_get_rate(clk) != LP55XX_CLK_32K) { - clk_disable_unprepare(clk); - goto use_internal_clk; - } - dev_info(&chip->cl->dev, "%dHz external clock used\n", LP55XX_CLK_32K); - chip->clk = clk; return true; use_internal_clk: @@ -995,9 +987,6 @@ static void lp55xx_deinit_device(struct lp55xx_chip *chip) { struct lp55xx_platform_data *pdata = chip->pdata; - if (chip->clk) - clk_disable_unprepare(chip->clk); - if (pdata->enable_gpiod) gpiod_set_value(pdata->enable_gpiod, 0); } diff --git a/drivers/leds/leds-lp55xx-common.h b/drivers/leds/leds-lp55xx-common.h index 1bb7c559662c..8fd64ec40919 100644 --- a/drivers/leds/leds-lp55xx-common.h +++ b/drivers/leds/leds-lp55xx-common.h @@ -193,7 +193,6 @@ struct lp55xx_engine { */ struct lp55xx_chip { struct i2c_client *cl; - struct clk *clk; struct lp55xx_platform_data *pdata; struct mutex lock; /* lock for user-space interface */ int num_leds;
lp55xx lp55xx_is_extclk_used get, enable clk and deinit_device disable and unprepare it. This can use a simplifies helper to cover. And no need to save clk pointer, this can save a little memory. Signed-off-by: Huan Yang <link@vivo.com> --- v2 -> v3: remove unneccessary suggested tag. v1 -> v2: remove clk pointer from lp55xx_chip drivers/leds/leds-lp55xx-common.c | 15 ++------------- drivers/leds/leds-lp55xx-common.h | 1 - 2 files changed, 2 insertions(+), 14 deletions(-)