| Message ID | 20240819120031.3884913-1-ruanjinjie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Mon, 19 Aug 2024 20:00:31 +0800, Jinjie Ruan wrote: > The sparse tool complains as follows: > > drivers/spi/spi-cadence-xspi.c:334:11: warning: > symbol 'cdns_mrvl_xspi_clk_div_list' was not declared. Should it be static? > > This symbol is not used outside spi-cadence-xspi.c, so marks it static. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [5/8] spi: cadence: Make cdns_mrvl_xspi_clk_div_list static commit: 802df33076cabfcb32b2c5b066c3af07f68e40fa All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 695a9bc1969a..aed98ab14334 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -331,7 +331,7 @@ static struct cdns_xspi_driver_data cdns_driver_data = { .mrvl_hw_overlay = false, }; -const int cdns_mrvl_xspi_clk_div_list[] = { +static const int cdns_mrvl_xspi_clk_div_list[] = { 4, //0x0 = Divide by 4. SPI clock is 200 MHz. 6, //0x1 = Divide by 6. SPI clock is 133.33 MHz. 8, //0x2 = Divide by 8. SPI clock is 100 MHz.
The sparse tool complains as follows: drivers/spi/spi-cadence-xspi.c:334:11: warning: symbol 'cdns_mrvl_xspi_clk_div_list' was not declared. Should it be static? This symbol is not used outside spi-cadence-xspi.c, so marks it static. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/spi/spi-cadence-xspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)