| Message ID | 20240816-cleanup-h-of-node-put-memory-v2-11-9eed0ee16b78@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | memory: simplify with scoped/cleanup.h for device nodes | expand |
On Fri, 16 Aug 2024 12:54:35 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Use dev_err_probe() to avoid dmesg flood on actual defer. This makes > the code also simpler. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v2: > 1. New patch > --- > drivers/memory/ti-aemif.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c > index e192db9e0e4b..360f2705b1ff 100644 > --- a/drivers/memory/ti-aemif.c > +++ b/drivers/memory/ti-aemif.c > @@ -345,10 +345,8 @@ static int aemif_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, aemif); > > aemif->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(aemif->clk)) { > - dev_err(dev, "cannot get clock 'aemif'\n"); > - return PTR_ERR(aemif->clk); > - } > + if (IS_ERR(aemif->clk)) > + return dev_err_probe(dev, PTR_ERR(aemif->clk), "cannot get clock 'aemif'\n"); Bit of a long line, so maybe wrap. Up to maintainers Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > ret = clk_prepare_enable(aemif->clk); > if (ret) >
diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index e192db9e0e4b..360f2705b1ff 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -345,10 +345,8 @@ static int aemif_probe(struct platform_device *pdev) platform_set_drvdata(pdev, aemif); aemif->clk = devm_clk_get(dev, NULL); - if (IS_ERR(aemif->clk)) { - dev_err(dev, "cannot get clock 'aemif'\n"); - return PTR_ERR(aemif->clk); - } + if (IS_ERR(aemif->clk)) + return dev_err_probe(dev, PTR_ERR(aemif->clk), "cannot get clock 'aemif'\n"); ret = clk_prepare_enable(aemif->clk); if (ret)
Use dev_err_probe() to avoid dmesg flood on actual defer. This makes the code also simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. New patch --- drivers/memory/ti-aemif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)