| Message ID | 20240816153251.2833702-2-andre.przywara@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition | expand |
On Fri, Aug 16, 2024 at 04:32:44PM +0100, Andre Przywara wrote: > The definition of GNU_SOURCE was recently centralised in an upper layer > kselftest Makefile, so the definition in the arm64 signal tests Makefile > is no longer needed. To make things worse, since both definitions are > not strictly identical, the compiler warns about it: > <command-line>: warning: "_GNU_SOURCE" redefined > <command-line>: note: this is the location of the previous definition Reviewed-by: Mark Brown <broonie@kernel.org>
diff --git a/tools/testing/selftests/arm64/signal/Makefile b/tools/testing/selftests/arm64/signal/Makefile index 8f5febaf1a9a2..37c8207b99cfc 100644 --- a/tools/testing/selftests/arm64/signal/Makefile +++ b/tools/testing/selftests/arm64/signal/Makefile @@ -2,7 +2,7 @@ # Copyright (C) 2019 ARM Limited # Additional include paths needed by kselftest.h and local headers -CFLAGS += -D_GNU_SOURCE -std=gnu99 -I. +CFLAGS += -std=gnu99 -I. SRCS := $(filter-out testcases/testcases.c,$(wildcard testcases/*.c)) PROGS := $(patsubst %.c,%,$(SRCS))
The definition of GNU_SOURCE was recently centralised in an upper layer kselftest Makefile, so the definition in the arm64 signal tests Makefile is no longer needed. To make things worse, since both definitions are not strictly identical, the compiler warns about it: <command-line>: warning: "_GNU_SOURCE" redefined <command-line>: note: this is the location of the previous definition Drop the definition in the arm64/signal Makefile. Fixes: cc937dad85ae ("selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk") Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- tools/testing/selftests/arm64/signal/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)