| Message ID | 20240807042210.1608026-1-sunilvl@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | serial: 8250_platform: Fix structure initialization warning | expand |
diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c index bdfb16bed4f2..d8c3c169a620 100644 --- a/drivers/tty/serial/8250/8250_platform.c +++ b/drivers/tty/serial/8250/8250_platform.c @@ -108,11 +108,12 @@ void __init serial8250_isa_init_ports(void) static int serial8250_platform_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct uart_8250_port uart = { 0 }; + struct uart_8250_port uart; struct resource *regs; unsigned char iotype; int ret, line; + memset(&uart, 0, sizeof(uart)); regs = platform_get_resource(pdev, IORESOURCE_IO, 0); if (regs) { uart.port.iobase = regs->start;
Use memset to initialize the uart structure instead of universal zero initializer to fix the below warning. drivers/tty/serial/8250/8250_platform.c: In function 'serial8250_platform_probe': drivers/tty/serial/8250/8250_platform.c:111:40: warning: excess elements in struct initializer 111 | struct uart_8250_port uart = { 0 }; | ^ drivers/tty/serial/8250/8250_platform.c:111:40: note: (near initialization for 'uart.port.lock.<anonymous>.rlock.raw_lock') Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407310023.h0JgJG1C-lkp@intel.com/ Fixes: d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices") Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> --- drivers/tty/serial/8250/8250_platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)