| Message ID | 20240730-qca6390_fix-v1-1-e0340a511756@icloud.com |
|---|---|
| State | New |
| Headers | show |
| Series | Bluetooth: hci_qca: [Don't Merge] For QCA6390 regression debugging. | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=874645
---Test result---
Test Summary:
CheckPatch FAIL 0.91 seconds
GitLint FAIL 0.58 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 30.33 seconds
CheckAllWarning PASS 32.45 seconds
CheckSparse PASS 38.40 seconds
CheckSmatch PASS 102.24 seconds
BuildKernel32 PASS 28.87 seconds
TestRunnerSetup PASS 526.99 seconds
TestRunner_l2cap-tester PASS 22.24 seconds
TestRunner_iso-tester FAIL 35.02 seconds
TestRunner_bnep-tester PASS 5.04 seconds
TestRunner_mgmt-tester PASS 113.71 seconds
TestRunner_rfcomm-tester PASS 7.72 seconds
TestRunner_sco-tester PASS 15.26 seconds
TestRunner_ioctl-tester PASS 9.16 seconds
TestRunner_mesh-tester PASS 6.23 seconds
TestRunner_smp-tester PASS 7.15 seconds
TestRunner_userchan-tester PASS 5.34 seconds
IncrementalBuild PASS 28.66 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: hci_qca: [Don't Merge] For QCA6390 regression debugging.
WARNING: Consider removing the code enclosed by this #if 0 and its #endif
#103: FILE: drivers/bluetooth/hci_qca.c:2191:
+#if 0
WARNING: Missing a blank line after declarations
#118: FILE: drivers/bluetooth/hci_qca.c:2427:
+ long x_err = 0;
+ if (IS_ERR(qcadev->bt_power->pwrseq))
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#121: FILE: drivers/bluetooth/hci_qca.c:2430:
+ if (x_err == -ENOSYS ||
total: 0 errors, 3 warnings, 37 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13745330.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: hci_qca: [Don't Merge] For QCA6390 regression debugging.
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "Bluetooth: hci_qca: [Don't Merge] For QCA6390 regression debugging."
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 116 (95.1%), Failed: 2, Not Run: 4
Failed Test Cases
ISO Connect Suspend - Success Failed 6.197 seconds
ISO Connect2 Suspend - Success Failed 4.227 seconds
---
Regards,
Linux Bluetooth
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index ca6466676902..3ae014af7f1f 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -2187,9 +2187,12 @@ static void qca_power_shutdown(struct hci_uart *hu) } break; + /* what to do ? */ +#if 0 case QCA_QCA6390: pwrseq_power_off(qcadev->bt_power->pwrseq); break; +#endif default: gpiod_set_value_cansleep(qcadev->bt_en, 0); @@ -2418,11 +2421,25 @@ static int qca_serdev_probe(struct serdev_device *serdev) case QCA_QCA6390: qcadev->bt_power->pwrseq = devm_pwrseq_get(&serdev->dev, "bluetooth"); + + { + long x_err = 0; + if (IS_ERR(qcadev->bt_power->pwrseq)) + x_err = PTR_ERR(qcadev->bt_power->pwrseq); + dev_info(&serdev->dev, "x_err(%lu)\n", x_err); + if (x_err == -ENOSYS || + (x_err == -ENODEV || x_err == -ENOENT)) { + qcadev->bt_power->pwrseq = NULL; + goto do_default; + } + } + if (IS_ERR(qcadev->bt_power->pwrseq)) return PTR_ERR(qcadev->bt_power->pwrseq); break; default: +do_default: qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(qcadev->bt_en)) {
For QCA6390 regression debugging. Signed-off-by: Zijun Hu <zijun_hu@icloud.com> --- drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) --- base-commit: 7a27b0ac58abccdf46e89bea9ed9f81a496132ab change-id: 20240729-qca6390_fix-df8f6f0a5070 Best regards,