diff mbox series

usb: gadget: f_fs: Define pr_fmt

Message ID 20240729-f_fs-pr_fmt-v1-1-8a0fc3196201@quicinc.com
State New
Headers show
Series usb: gadget: f_fs: Define pr_fmt | expand

Commit Message

Bjorn Andersson July 29, 2024, 10:53 p.m. UTC
The majority of log entries of f_fs are generated with no indication of
their origin. Prefix these, using pr_fmt, to make the kernel log
clearer.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 drivers/usb/gadget/function/f_fs.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 931a3b3bccc96e7708c82b30b2b5fa82dfd04890
change-id: 20240729-f_fs-pr_fmt-0c610cc10d27

Best regards,

Comments

Greg Kroah-Hartman July 30, 2024, 5 a.m. UTC | #1
On Mon, Jul 29, 2024 at 03:53:50PM -0700, Bjorn Andersson wrote:
> The majority of log entries of f_fs are generated with no indication of
> their origin. Prefix these, using pr_fmt, to make the kernel log
> clearer.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  drivers/usb/gadget/function/f_fs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index d8b096859337..14ee43cb27b6 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -10,6 +10,7 @@
>   * Copyright (C) 2003 Agilent Technologies
>   */
>  
> +#define pr_fmt(fmt) "f_fs: " fmt

Why not fix the driver up to use the proper dev_*() printing functions
instead?

Or, use KBUILD_MODNAME?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
index d8b096859337..14ee43cb27b6 100644
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -10,6 +10,7 @@ 
  * Copyright (C) 2003 Agilent Technologies
  */
 
+#define pr_fmt(fmt) "f_fs: " fmt
 
 /* #define DEBUG */
 /* #define VERBOSE_DEBUG */