| Message ID | dcb78f4958be3ad322168ccac6214991af44c884.1721910373.git.jerome.forissier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce the lwIP network stack | expand |
On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: > Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and > selects NET_LWIP instead of NET. This config has all the supported net > commands enabled. > > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > configs/qemu_arm64_lwip_defconfig | 5 +++++ > 1 file changed, 5 insertions(+) > create mode 100644 configs/qemu_arm64_lwip_defconfig > > diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > new file mode 100644 > index 00000000000..1afef04d7a0 > --- /dev/null > +++ b/configs/qemu_arm64_lwip_defconfig > @@ -0,0 +1,5 @@ > +#include <configs/qemu_arm64_defconfig> > +CONFIG_NET_LWIP=y > +CONFIG_CMD_DNS=y > +CONFIG_CMD_WGET=y > +CONFIG_EFI_HTTP_BOOT=y This doesn't work, you need: diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig index 1afef04d7a04..d3d8ef16e668 100644 --- a/configs/qemu_arm64_lwip_defconfig +++ b/configs/qemu_arm64_lwip_defconfig @@ -1,4 +1,8 @@ #include <configs/qemu_arm64_defconfig> + +CONFIG_ARM=y +CONFIG_ARCH_QEMU=y + CONFIG_NET_LWIP=y CONFIG_CMD_DNS=y CONFIG_CMD_WGET=y
On 7/25/24 17:58, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: > >> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and >> selects NET_LWIP instead of NET. This config has all the supported net >> commands enabled. >> >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> >> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> >> --- >> configs/qemu_arm64_lwip_defconfig | 5 +++++ >> 1 file changed, 5 insertions(+) >> create mode 100644 configs/qemu_arm64_lwip_defconfig >> >> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig >> new file mode 100644 >> index 00000000000..1afef04d7a0 >> --- /dev/null >> +++ b/configs/qemu_arm64_lwip_defconfig >> @@ -0,0 +1,5 @@ >> +#include <configs/qemu_arm64_defconfig> >> +CONFIG_NET_LWIP=y >> +CONFIG_CMD_DNS=y >> +CONFIG_CMD_WGET=y >> +CONFIG_EFI_HTTP_BOOT=y > > This doesn't work, How so? I've used "make qemu_arm64_lwip_defconfig" hundreds of time to build for arm64 QEMU :o > you need: > > diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > index 1afef04d7a04..d3d8ef16e668 100644 > --- a/configs/qemu_arm64_lwip_defconfig > +++ b/configs/qemu_arm64_lwip_defconfig > @@ -1,4 +1,8 @@ > #include <configs/qemu_arm64_defconfig> > + > +CONFIG_ARM=y > +CONFIG_ARCH_QEMU=y Those are both set to =y in my .config after "make qemu_arm64_lwip_defconfig" > + > CONFIG_NET_LWIP=y > CONFIG_CMD_DNS=y > CONFIG_CMD_WGET=y > Thanks,
On Thu, Jul 25, 2024 at 06:10:48PM +0200, Jerome Forissier wrote: > > > On 7/25/24 17:58, Tom Rini wrote: > > On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: > > > >> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and > >> selects NET_LWIP instead of NET. This config has all the supported net > >> commands enabled. > >> > >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > >> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > >> --- > >> configs/qemu_arm64_lwip_defconfig | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> create mode 100644 configs/qemu_arm64_lwip_defconfig > >> > >> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > >> new file mode 100644 > >> index 00000000000..1afef04d7a0 > >> --- /dev/null > >> +++ b/configs/qemu_arm64_lwip_defconfig > >> @@ -0,0 +1,5 @@ > >> +#include <configs/qemu_arm64_defconfig> > >> +CONFIG_NET_LWIP=y > >> +CONFIG_CMD_DNS=y > >> +CONFIG_CMD_WGET=y > >> +CONFIG_EFI_HTTP_BOOT=y > > > > This doesn't work, > > How so? I've used "make qemu_arm64_lwip_defconfig" hundreds of time to build for > arm64 QEMU :o Yes, but buildman (and CI) are in a chicken-and-egg situation without a few more details in the new defconfig, sadly.
On 7/25/24 18:25, Tom Rini wrote: > On Thu, Jul 25, 2024 at 06:10:48PM +0200, Jerome Forissier wrote: >> >> >> On 7/25/24 17:58, Tom Rini wrote: >>> On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: >>> >>>> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and >>>> selects NET_LWIP instead of NET. This config has all the supported net >>>> commands enabled. >>>> >>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> >>>> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> >>>> --- >>>> configs/qemu_arm64_lwip_defconfig | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> create mode 100644 configs/qemu_arm64_lwip_defconfig >>>> >>>> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig >>>> new file mode 100644 >>>> index 00000000000..1afef04d7a0 >>>> --- /dev/null >>>> +++ b/configs/qemu_arm64_lwip_defconfig >>>> @@ -0,0 +1,5 @@ >>>> +#include <configs/qemu_arm64_defconfig> >>>> +CONFIG_NET_LWIP=y >>>> +CONFIG_CMD_DNS=y >>>> +CONFIG_CMD_WGET=y >>>> +CONFIG_EFI_HTTP_BOOT=y >>> >>> This doesn't work, >> >> How so? I've used "make qemu_arm64_lwip_defconfig" hundreds of time to build for >> arm64 QEMU :o > > Yes, but buildman (and CI) are in a chicken-and-egg situation without a > few more details in the new defconfig, sadly. With: $ cat configs/qemu_arm64_lwip_defconfig #include <configs/qemu_arm64_defconfig> CONFIG_ARM=y CONFIG_ARCH_QEMU=y CONFIG_NET_LWIP=y CONFIG_CMD_DNS=y CONFIG_CMD_WGET=y CONFIG_EFI_HTTP_BOOT=y ...I get: $ make qemu_arm64_lwip_defconfig generated_defconfig:71:warning: override: reassigning to symbol ARM generated_defconfig:71:warning: override: ARM changes choice state generated_defconfig:72:warning: override: reassigning to symbol ARCH_QEMU generated_defconfig:72:warning: override: ARCH_QEMU changes choice state # # configuration written to .config # It is OK?
On Fri, Jul 26, 2024 at 02:27:05PM +0200, Jerome Forissier wrote: > > > On 7/25/24 18:25, Tom Rini wrote: > > On Thu, Jul 25, 2024 at 06:10:48PM +0200, Jerome Forissier wrote: > >> > >> > >> On 7/25/24 17:58, Tom Rini wrote: > >>> On Thu, Jul 25, 2024 at 02:57:37PM +0200, Jerome Forissier wrote: > >>> > >>>> Add qemu_arm64_lwip_defconfig which #include's qemu_arm64_defconfig and > >>>> selects NET_LWIP instead of NET. This config has all the supported net > >>>> commands enabled. > >>>> > >>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > >>>> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > >>>> --- > >>>> configs/qemu_arm64_lwip_defconfig | 5 +++++ > >>>> 1 file changed, 5 insertions(+) > >>>> create mode 100644 configs/qemu_arm64_lwip_defconfig > >>>> > >>>> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > >>>> new file mode 100644 > >>>> index 00000000000..1afef04d7a0 > >>>> --- /dev/null > >>>> +++ b/configs/qemu_arm64_lwip_defconfig > >>>> @@ -0,0 +1,5 @@ > >>>> +#include <configs/qemu_arm64_defconfig> > >>>> +CONFIG_NET_LWIP=y > >>>> +CONFIG_CMD_DNS=y > >>>> +CONFIG_CMD_WGET=y > >>>> +CONFIG_EFI_HTTP_BOOT=y > >>> > >>> This doesn't work, > >> > >> How so? I've used "make qemu_arm64_lwip_defconfig" hundreds of time to build for > >> arm64 QEMU :o > > > > Yes, but buildman (and CI) are in a chicken-and-egg situation without a > > few more details in the new defconfig, sadly. > > With: > > $ cat configs/qemu_arm64_lwip_defconfig > #include <configs/qemu_arm64_defconfig> > > CONFIG_ARM=y > CONFIG_ARCH_QEMU=y > > CONFIG_NET_LWIP=y > CONFIG_CMD_DNS=y > CONFIG_CMD_WGET=y > CONFIG_EFI_HTTP_BOOT=y > > ...I get: > > $ make qemu_arm64_lwip_defconfig > generated_defconfig:71:warning: override: reassigning to symbol ARM > generated_defconfig:71:warning: override: ARM changes choice state > generated_defconfig:72:warning: override: reassigning to symbol ARCH_QEMU > generated_defconfig:72:warning: override: ARCH_QEMU changes choice state > # > # configuration written to .config > # > > It is OK? Yes, that's fine. Thanks.
diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig new file mode 100644 index 00000000000..1afef04d7a0 --- /dev/null +++ b/configs/qemu_arm64_lwip_defconfig @@ -0,0 +1,5 @@ +#include <configs/qemu_arm64_defconfig> +CONFIG_NET_LWIP=y +CONFIG_CMD_DNS=y +CONFIG_CMD_WGET=y +CONFIG_EFI_HTTP_BOOT=y