diff mbox series

[v4] rteval: run cyclictest using '--default-system' when setting idle states

Message ID 20240724191225.1722773-2-ashelat@redhat.com
State New
Headers show
Series [v4] rteval: run cyclictest using '--default-system' when setting idle states | expand

Commit Message

Anubhav Shelat July 24, 2024, 7:12 p.m. UTC 
When running cyclictest in rteval, cyclictest automatically disables
idle states. This means whenever the user sets the idle state of a cpu
list using '--idle-set' it is overridden by cyclictest.

To fix this, the variable 'usingCpupower' is appended to the parameter
dictionary that's passed to the Cyclictest measurement object which executes
cyclictest in rteval.

If '--idle-set' is specified when running rteval,
'usingCpupower' is set to true and the '--default-system' option is
appended to the cyclictest command, which will prevent cyclictest from
disabling cstates.

Signed-off-by: Anubhav Shelat <ashelat@redhat.com>
---
 rteval/__init__.py                       | 3 ++-
 rteval/modules/measurement/cyclictest.py | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/rteval/__init__.py b/rteval/__init__.py
index 226d14f80f48..b042102f4553 100644
--- a/rteval/__init__.py
+++ b/rteval/__init__.py
@@ -124,7 +124,8 @@  class RtEval(rtevalReport):
                       'memsize':self._sysinfo.mem_get_size(),
                       'numanodes':self._sysinfo.mem_get_numa_nodes(),
                       'duration': float(self.__rtevcfg.duration),
-                      }
+                      'usingCpupower': self.__rtevcfg.usingCpupower
+                  }
             self._loadmods.Setup(params)
 
         self.__logger.log(Log.INFO, "Preparing measurement modules")
diff --git a/rteval/modules/measurement/cyclictest.py b/rteval/modules/measurement/cyclictest.py
index a9f5b0c4fba7..fffc8fe27681 100644
--- a/rteval/modules/measurement/cyclictest.py
+++ b/rteval/modules/measurement/cyclictest.py
@@ -251,6 +251,9 @@  class Cyclictest(rtevalModulePrototype):
         self.__cmd.append(f'-t{self.__numcores}')
         self.__cmd.append(f'-a{self.__cpulist}')
 
+        if (self.__cfg.usingCpupower):
+            self.__cmd.append('--default-system')
+
         if 'threads' in self.__cfg and self.__cfg.threads:
             self.__cmd.append(f"-t{int(self.__cfg.threads)}")