| Message ID | 20240722095147.3372-4-a39.skl@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | MSM8953/MSM8976 ASoC support | expand |
On 22/07/2024 11:51, Adam Skladowski wrote: > Document MSM8953/MSM8976 QDSP6 cards. > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> ... > + then: > properties: > - reg: false > - reg-names: false > + reg: > + items: > + - description: Microphone I/O mux register address > + - description: Speaker I/O mux register address > + - description: Quinary Mi2S I/O mux register address > + reg-names: > + items: > + - const: mic-iomux > + - const: spkr-iomux > + - const: quin-iomux > + required: > + - compatible > + - model Don't duplicate. It's already required. > + - reg > + - reg-names And what happened with all other variants? Why do you affect them? > > additionalProperties: false > Best regards, Krzysztof
On 23/07/2024 10:19, Krzysztof Kozlowski wrote: > On 22/07/2024 11:51, Adam Skladowski wrote: >> Document MSM8953/MSM8976 QDSP6 cards. >> >> Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > > ... > >> + then: >> properties: >> - reg: false >> - reg-names: false >> + reg: >> + items: >> + - description: Microphone I/O mux register address >> + - description: Speaker I/O mux register address >> + - description: Quinary Mi2S I/O mux register address >> + reg-names: >> + items: >> + - const: mic-iomux >> + - const: spkr-iomux >> + - const: quin-iomux >> + required: >> + - compatible >> + - model > > Don't duplicate. It's already required. I suggest to rebase on top of my patch. Optionally, take it into your patchset. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index b2e15ebbd1bc..3b5f8adba725 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard + - qcom,msm8953-qdsp6-sndcard + - qcom,msm8976-qdsp6-sndcard - qcom,qcm6490-idp-sndcard - qcom,qcs6490-rb3gen2-sndcard - qcom,qrb5165-rb5-sndcard @@ -144,10 +146,30 @@ allOf: - model - reg - reg-names - else: + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8953-qdsp6-sndcard + - qcom,msm8976-qdsp6-sndcard + then: properties: - reg: false - reg-names: false + reg: + items: + - description: Microphone I/O mux register address + - description: Speaker I/O mux register address + - description: Quinary Mi2S I/O mux register address + reg-names: + items: + - const: mic-iomux + - const: spkr-iomux + - const: quin-iomux + required: + - compatible + - model + - reg + - reg-names additionalProperties: false
Document MSM8953/MSM8976 QDSP6 cards. Signed-off-by: Adam Skladowski <a39.skl@gmail.com> --- .../bindings/sound/qcom,sm8250.yaml | 28 +++++++++++++++++-- 1 file changed, 25 insertions(+), 3 deletions(-)