| Message ID | 20240718-btaml-v2-1-1392b2e21183@amlogic.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Amlogic HCI UART | expand |
On 18/07/2024 09:42, Yang Li via B4 Relay wrote: > From: Yang Li <yang.li@amlogic.com> > > Add binding document for Amlogic Bluetooth chipsets attached over UART. > > Signed-off-by: Yang Li <yang.li@amlogic.com> > --- > .../bindings/net/bluetooth/amlogic,w155s2-bt.yaml | 66 ++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml > new file mode 100644 > index 000000000000..2e433d5692ff > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2024 Amlogic, Inc. All rights reserved > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/bluetooth/amlogic,w155s2-bt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Bluetooth chips > + > +description: > + This binding describes UART-attached Amlogic bluetooth chips. <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> > + > +maintainers: > + - Yang Li <yang.li@amlogic.com> > + > +properties: > + compatible: > + oneOf: > + - const: amlogic,w155s2-bt > + - items: > + - enum: > + - amlogic,w265s1-bt > + - amlogic,w265p1-bt > + - amlogic,w265s2-bt > + - const: amlogic,w155s2-bt > + > + bt-enable-gpios: enable-gpios > + maxItems: 1 > + description: gpio specifier used to enable BT Drop, redundant. > + > + bt-supply: It's called "bt" in schematics or datasheet? Feels unusual. Please list all the pins if you claim that's a real name. > + description: bluetooth chip 3.3V supply regulator handle > + > + clocks: > + maxItems: 1 > + description: clock provided to the controller (32.768KHz) > + > + antenna-number: > + default: 1 > + description: device supports up to two antennas Keep it consistent - either descriptions are the last property or somewhere else. Usually the last. > + $ref: /schemas/types.yaml#/definitions/uint32 And what does it mean? What happens if BT uses antenna number 2, not 1? What is connected to the other antenna? It really feels useless to say which antenna is connected to hardware. > + > + firmware-name: > + description: specify the path of firmware bin to load Missing maxItems > + $ref: /schemas/types.yaml#/definitions/string-array That's redundant, drop. > + Best regards, Krzysztof
Dear Krzysztof Thanks. On 2024/7/18 19:40, Krzysztof Kozlowski wrote: > On 18/07/2024 09:42, Yang Li via B4 Relay wrote: >> From: Yang Li <yang.li@amlogic.com> >> >> Add binding document for Amlogic Bluetooth chipsets attached over UART. >> >> Signed-off-by: Yang Li <yang.li@amlogic.com> >> --- >> .../bindings/net/bluetooth/amlogic,w155s2-bt.yaml | 66 ++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >> new file mode 100644 >> index 000000000000..2e433d5692ff >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2024 Amlogic, Inc. All rights reserved >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/bluetooth/amlogic,w155s2-bt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic Bluetooth chips >> + >> +description: >> + This binding describes UART-attached Amlogic bluetooth chips. > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > </form letter> Apologies for the earlier omission. I have amended the description of the UART-attached Amlogic Bluetooth chips in the patch: "This binding describes Amlogic Bluetooth chips connected via UART, which function as dual-radio devices supporting Wi-Fi and Bluetooth. It operates on the H4 protocol over a 4-wire UART, with RTS and CTS lines used for firmware download. It supports Bluetooth and Wi-Fi coexistence." >> + >> +maintainers: >> + - Yang Li <yang.li@amlogic.com> >> + >> +properties: >> + compatible: >> + oneOf: >> + - const: amlogic,w155s2-bt >> + - items: >> + - enum: >> + - amlogic,w265s1-bt >> + - amlogic,w265p1-bt >> + - amlogic,w265s2-bt >> + - const: amlogic,w155s2-bt >> + >> + bt-enable-gpios: > enable-gpios will do. > >> + maxItems: 1 >> + description: gpio specifier used to enable BT > Drop, redundant. will do. > >> + >> + bt-supply: > It's called "bt" in schematics or datasheet? Feels unusual. Please list > all the pins if you claim that's a real name. > Yes, you are correct, the actual name is 'vddio-supply.' I initially intended to differentiate it from WiFi, but it seems unnecessary. I will change it to 'vddio-supply'. > >> + description: bluetooth chip 3.3V supply regulator handle >> + >> + clocks: >> + maxItems: 1 >> + description: clock provided to the controller (32.768KHz) >> + >> + antenna-number: >> + default: 1 >> + description: device supports up to two antennas > Keep it consistent - either descriptions are the last property or > somewhere else. Usually the last. > >> + $ref: /schemas/types.yaml#/definitions/uint32 > And what does it mean? What happens if BT uses antenna number 2, not 1? > What is connected to the other antenna? It really feels useless to say > which antenna is connected to hardware. Sorry, the antenna description was incorrect, it should specify whether Bluetooth and WiFi coexist. I will change it as below: aml,work-mode: type: boolean description: specifywhether Bluetooth and WiFi coexist. >> + >> + firmware-name: >> + description: specify the path of firmware bin to load > Missing maxItems will do. > >> + $ref: /schemas/types.yaml#/definitions/string-array > That's redundant, drop. will do. > >> + > > Best regards, > Krzysztof >
On 19/07/2024 10:20, Yang Li wrote: > Dear Krzysztof > > Thanks. > > On 2024/7/18 19:40, Krzysztof Kozlowski wrote: >> On 18/07/2024 09:42, Yang Li via B4 Relay wrote: >>> From: Yang Li <yang.li@amlogic.com> >>> >>> Add binding document for Amlogic Bluetooth chipsets attached over UART. >>> >>> Signed-off-by: Yang Li <yang.li@amlogic.com> >>> --- >>> .../bindings/net/bluetooth/amlogic,w155s2-bt.yaml | 66 ++++++++++++++++++++++ >>> 1 file changed, 66 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >>> new file mode 100644 >>> index 000000000000..2e433d5692ff >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >>> @@ -0,0 +1,66 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright (C) 2024 Amlogic, Inc. All rights reserved >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/bluetooth/amlogic,w155s2-bt.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Amlogic Bluetooth chips >>> + >>> +description: >>> + This binding describes UART-attached Amlogic bluetooth chips. >> <form letter> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. >> >> Thank you. >> </form letter> > > Apologies for the earlier omission. I have amended the description of the > > UART-attached Amlogic Bluetooth chips in the patch: > > "This binding describes Amlogic Bluetooth chips connected via UART, > > which function as dual-radio devices supporting Wi-Fi and Bluetooth. > > It operates on the H4 protocol over a 4-wire UART, with RTS and CTS lines > > used for firmware download. It supports Bluetooth and Wi-Fi coexistence." You still say what is the binding which is pointless. Binding is a binding... awesome. No, say what the hardware is. >> >>> + description: bluetooth chip 3.3V supply regulator handle >>> + >>> + clocks: >>> + maxItems: 1 >>> + description: clock provided to the controller (32.768KHz) >>> + >>> + antenna-number: >>> + default: 1 >>> + description: device supports up to two antennas >> Keep it consistent - either descriptions are the last property or >> somewhere else. Usually the last. >> >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> And what does it mean? What happens if BT uses antenna number 2, not 1? >> What is connected to the other antenna? It really feels useless to say >> which antenna is connected to hardware. > > Sorry, the antenna description was incorrect, it should specify whether > > Bluetooth and WiFi coexist. I will change it as below: > > aml,work-mode: > type: boolean > description: specifywhether Bluetooth and WiFi coexist. So one device can be used on different boards - some without WiFi antenna? But, why in the binding of bluetooth you describe whether there is WiFi antenna? Best regards, Krzysztof
On 2024/7/21 2:25, Krzysztof Kozlowski wrote: > On 19/07/2024 10:20, Yang Li wrote: >> Dear Krzysztof >> >> Thanks. >> >> On 2024/7/18 19:40, Krzysztof Kozlowski wrote: >>> On 18/07/2024 09:42, Yang Li via B4 Relay wrote: >>>> From: Yang Li <yang.li@amlogic.com> >>>> >>>> Add binding document for Amlogic Bluetooth chipsets attached over UART. >>>> >>>> Signed-off-by: Yang Li <yang.li@amlogic.com> >>>> --- >>>> .../bindings/net/bluetooth/amlogic,w155s2-bt.yaml | 66 ++++++++++++++++++++++ >>>> 1 file changed, 66 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >>>> new file mode 100644 >>>> index 000000000000..2e433d5692ff >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml >>>> @@ -0,0 +1,66 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# Copyright (C) 2024 Amlogic, Inc. All rights reserved >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/bluetooth/amlogic,w155s2-bt.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Amlogic Bluetooth chips >>>> + >>>> +description: >>>> + This binding describes UART-attached Amlogic bluetooth chips. >>> <form letter> >>> This is a friendly reminder during the review process. >>> >>> It seems my or other reviewer's previous comments were not fully >>> addressed. Maybe the feedback got lost between the quotes, maybe you >>> just forgot to apply it. Please go back to the previous discussion and >>> either implement all requested changes or keep discussing them. >>> >>> Thank you. >>> </form letter> >> Apologies for the earlier omission. I have amended the description of the >> >> UART-attached Amlogic Bluetooth chips in the patch: >> >> "This binding describes Amlogic Bluetooth chips connected via UART, >> >> which function as dual-radio devices supporting Wi-Fi and Bluetooth. >> >> It operates on the H4 protocol over a 4-wire UART, with RTS and CTS lines >> >> used for firmware download. It supports Bluetooth and Wi-Fi coexistence." > You still say what is the binding which is pointless. Binding is a > binding... awesome. No, say what the hardware is. > Hi Krzysztof Seeking feedback on proposed changes: "The W155S2 is Amlogic's Bluetooth and Wi-Fi combo chip. It works on the standard H4 protocol via a 4-wire UART interface, and supporting maximum baud rates up to 4 Mbps." >>>> + description: bluetooth chip 3.3V supply regulator handle >>>> + >>>> + clocks: >>>> + maxItems: 1 >>>> + description: clock provided to the controller (32.768KHz) >>>> + >>>> + antenna-number: >>>> + default: 1 >>>> + description: device supports up to two antennas >>> Keep it consistent - either descriptions are the last property or >>> somewhere else. Usually the last. >>> >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> And what does it mean? What happens if BT uses antenna number 2, not 1? >>> What is connected to the other antenna? It really feels useless to say >>> which antenna is connected to hardware. >> Sorry, the antenna description was incorrect, it should specify whether >> >> Bluetooth and WiFi coexist. I will change it as below: >> >> aml,work-mode: >> type: boolean >> description: specifywhether Bluetooth and WiFi coexist. > So one device can be used on different boards - some without WiFi > antenna? But, why in the binding of bluetooth you describe whether there > is WiFi antenna? Yes, it can be used on dirfferent boards. The device can operate in both standalone mode and coexistence mode. typically running standalone mode. Therefore, I would like to revise the description as follows: aml,coexisting: type: boolean description: Enable coexistence mode, allowing shared antenna usage with Wi-Fi. > > Best regards, > Krzysztof >
On 22/07/2024 09:41, Yang Li wrote: >>>>> + description: bluetooth chip 3.3V supply regulator handle >>>>> + >>>>> + clocks: >>>>> + maxItems: 1 >>>>> + description: clock provided to the controller (32.768KHz) >>>>> + >>>>> + antenna-number: >>>>> + default: 1 >>>>> + description: device supports up to two antennas >>>> Keep it consistent - either descriptions are the last property or >>>> somewhere else. Usually the last. >>>> >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> And what does it mean? What happens if BT uses antenna number 2, not 1? >>>> What is connected to the other antenna? It really feels useless to say >>>> which antenna is connected to hardware. >>> Sorry, the antenna description was incorrect, it should specify whether >>> >>> Bluetooth and WiFi coexist. I will change it as below: >>> >>> aml,work-mode: >>> type: boolean >>> description: specifywhether Bluetooth and WiFi coexist. >> So one device can be used on different boards - some without WiFi >> antenna? But, why in the binding of bluetooth you describe whether there >> is WiFi antenna? > > Yes, it can be used on dirfferent boards. The device can operate in both Please do not respond to only partial part of the comment. It is obvious device can work on different boards. You do not have to confirm it. The question was different - why do you need this property? I gave you possible answer, but you skipped this and answered with obvious statement. > standalone mode and coexistence mode. typically running standalone mode. > > Therefore, I would like to revise the description as follows: > > aml,coexisting: > type: boolean > description: Enable coexistence mode, allowing shared antenna usage > with Wi-Fi. Why this is not enabled always? Best regards, Krzysztof
On 2024/7/22 15:58, Krzysztof Kozlowski wrote: > On 22/07/2024 09:41, Yang Li wrote: >>>>>> + description: bluetooth chip 3.3V supply regulator handle >>>>>> + >>>>>> + clocks: >>>>>> + maxItems: 1 >>>>>> + description: clock provided to the controller (32.768KHz) >>>>>> + >>>>>> + antenna-number: >>>>>> + default: 1 >>>>>> + description: device supports up to two antennas >>>>> Keep it consistent - either descriptions are the last property or >>>>> somewhere else. Usually the last. >>>>> >>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> And what does it mean? What happens if BT uses antenna number 2, not 1? >>>>> What is connected to the other antenna? It really feels useless to say >>>>> which antenna is connected to hardware. >>>> Sorry, the antenna description was incorrect, it should specify whether >>>> >>>> Bluetooth and WiFi coexist. I will change it as below: >>>> >>>> aml,work-mode: >>>> type: boolean >>>> description: specifywhether Bluetooth and WiFi coexist. >>> So one device can be used on different boards - some without WiFi >>> antenna? But, why in the binding of bluetooth you describe whether there >>> is WiFi antenna? >> Yes, it can be used on dirfferent boards. The device can operate in both > Please do not respond to only partial part of the comment. It is obvious > device can work on different boards. You do not have to confirm it. The > question was different - why do you need this property? I gave you > possible answer, but you skipped this and answered with obvious statement. I'm sorry. I didn't explain it clearly. Board design should be optimized for specific use cases: use the standalone mode for high-speed, stable, and Bluetooth-only applications; opt for the coexistence mode in cost-sensitive scenarios with lower performance demands. Once the hardware is determined, the user needs to configure the working mode of the firmware. > >> standalone mode and coexistence mode. typically running standalone mode. >> >> Therefore, I would like to revise the description as follows: >> >> aml,coexisting: >> type: boolean >> description: Enable coexistence mode, allowing shared antenna usage >> with Wi-Fi. > Why this is not enabled always? The board design determines whether to enable this property. Well, I know I should clearly describe why this property is enabled here, so I modify it as follows: aml,coexisting: type: boolean description: Enable co-existence mode on boards sharing antennas with Wi-Fi. > > Best regards, > Krzysztof >
On 2024/7/24 14:48, Yang Li wrote: > > On 2024/7/22 15:58, Krzysztof Kozlowski wrote: >> On 22/07/2024 09:41, Yang Li wrote: >>>>>>> + description: bluetooth chip 3.3V supply regulator handle >>>>>>> + >>>>>>> + clocks: >>>>>>> + maxItems: 1 >>>>>>> + description: clock provided to the controller (32.768KHz) >>>>>>> + >>>>>>> + antenna-number: >>>>>>> + default: 1 >>>>>>> + description: device supports up to two antennas >>>>>> Keep it consistent - either descriptions are the last property or >>>>>> somewhere else. Usually the last. >>>>>> >>>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>>> And what does it mean? What happens if BT uses antenna number 2, >>>>>> not 1? >>>>>> What is connected to the other antenna? It really feels useless >>>>>> to say >>>>>> which antenna is connected to hardware. >>>>> Sorry, the antenna description was incorrect, it should specify >>>>> whether >>>>> >>>>> Bluetooth and WiFi coexist. I will change it as below: >>>>> >>>>> aml,work-mode: >>>>> type: boolean >>>>> description: specifywhether Bluetooth and WiFi coexist. >>>> So one device can be used on different boards - some without WiFi >>>> antenna? But, why in the binding of bluetooth you describe whether >>>> there >>>> is WiFi antenna? >>> Yes, it can be used on dirfferent boards. The device can operate in >>> both >> Please do not respond to only partial part of the comment. It is obvious >> device can work on different boards. You do not have to confirm it. The >> question was different - why do you need this property? I gave you >> possible answer, but you skipped this and answered with obvious >> statement. > > I'm sorry. I didn't explain it clearly. > > Board design should be optimized for specific use cases: use the > standalone mode for high-speed, stable, and Bluetooth-only > applications; opt for the coexistence mode in cost-sensitive scenarios > with lower performance demands. Once the hardware is determined, the > user needs to configure the working mode of the firmware. > >> >>> standalone mode and coexistence mode. typically running standalone >>> mode. >>> >>> Therefore, I would like to revise the description as follows: >>> >>> aml,coexisting: >>> type: boolean >>> description: Enable coexistence mode, allowing shared antenna >>> usage >>> with Wi-Fi. >> Why this is not enabled always? > > The board design determines whether to enable this property. > > Well, I know I should clearly describe why this property is enabled > here, so I modify it as follows: > > aml,coexisting: > type: boolean > description: Enable co-existence mode on boards sharing antennas > with Wi-Fi. > Hi Krzysztof After internal discussions, we determined that Bluetooth Controllers typically operate in standalone mode and are only configured for sharing upon customer-specific customization. Consequently, we have decided to remove this property. Please be advised that the third patch will be updated accordingly at a later date >> >> Best regards, >> Krzysztof >>
diff --git a/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml new file mode 100644 index 000000000000..2e433d5692ff --- /dev/null +++ b/Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2024 Amlogic, Inc. All rights reserved +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/bluetooth/amlogic,w155s2-bt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Bluetooth chips + +description: + This binding describes UART-attached Amlogic bluetooth chips. + +maintainers: + - Yang Li <yang.li@amlogic.com> + +properties: + compatible: + oneOf: + - const: amlogic,w155s2-bt + - items: + - enum: + - amlogic,w265s1-bt + - amlogic,w265p1-bt + - amlogic,w265s2-bt + - const: amlogic,w155s2-bt + + bt-enable-gpios: + maxItems: 1 + description: gpio specifier used to enable BT + + bt-supply: + description: bluetooth chip 3.3V supply regulator handle + + clocks: + maxItems: 1 + description: clock provided to the controller (32.768KHz) + + antenna-number: + default: 1 + description: device supports up to two antennas + $ref: /schemas/types.yaml#/definitions/uint32 + + firmware-name: + description: specify the path of firmware bin to load + $ref: /schemas/types.yaml#/definitions/string-array + +required: + - compatible + - bt-enable-gpios + - bt-supply + - clocks + - firmware-name + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + bluetooth { + compatible = "amlogic,w155s2-bt"; + bt-enable-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; + bt-supply = <&wcn_3v3>; + clocks = <&extclk>; + firmware-name = "amlogic/aml_w155s2_bt_uart.bin"; + }; +