| Message ID | 20240718184434.6307-3-robdclark@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02 | expand |
On 18.07.2024 8:44 PM, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Use the correct panel compatible, and wire up enable-gpio. It is wired > up in the same way as the x1e80100-crd. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
Hi, On Thu, Jul 18, 2024 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote: > > From: Rob Clark <robdclark@chromium.org> > > Use the correct panel compatible, and wire up enable-gpio. It is wired > up in the same way as the x1e80100-crd. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > index f569f0fbd1fc..37ef05f8c7e0 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > @@ -592,9 +592,13 @@ &mdss_dp3 { > > aux-bus { > panel { > - compatible = "edp-panel"; > + compatible = "samsung,atna45dc02"; Instead of the above, I believe you should use: compatible = "samsung,atna45dc02", "samsung,atna33xc20"; ...which makes the dts work without any code changes. This is what we decided upon for Stephen's panel [0] [0] https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org/ -Doug
On Thu, Jul 18, 2024 at 4:12 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Thu, Jul 18, 2024 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote: > > > > From: Rob Clark <robdclark@chromium.org> > > > > Use the correct panel compatible, and wire up enable-gpio. It is wired > > up in the same way as the x1e80100-crd. > > > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > --- > > .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > index f569f0fbd1fc..37ef05f8c7e0 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > > @@ -592,9 +592,13 @@ &mdss_dp3 { > > > > aux-bus { > > panel { > > - compatible = "edp-panel"; > > + compatible = "samsung,atna45dc02"; > > Instead of the above, I believe you should use: > > compatible = "samsung,atna45dc02", "samsung,atna33xc20"; > > ...which makes the dts work without any code changes. This is what we > decided upon for Stephen's panel [0] sure, that sounds reasonable.. I only saw the first version because that is what is in the x1e80100-next branch atm BR, -R > [0] https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org/ > > -Doug >
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts index f569f0fbd1fc..37ef05f8c7e0 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts @@ -592,9 +592,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45dc02"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -663,6 +667,13 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + }; +}; + &qupv3_0 { status = "okay"; };