| Message ID | 20240717094848.3536239-1-quic_varada@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info | expand |
On 17/07/2024 11:48, Varadarajan Narayanan wrote: > IPQ5332 has only three interrupts. Update the constraints > to fix the following dt_binding_check errors. > > interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > > Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding") > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v2: Fix patch version numbering. Incorrectly marked the first version as v0 > Add interrupts and interrupt-names for ipq5332 instead of clubbing it with > qcom,x1e80100-dwc3 > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index 6c5f962bbcf9..5e5cc2175526 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -235,6 +235,13 @@ allOf: > - const: core > - const: sleep > - const: mock_utmi > + interrupts: > + maxItems: 3 > + interrupt-names: > + items: > + - const: pwr_event > + - const: dp_hs_phy_irq > + - const: dm_hs_phy_irq Why are you duplicating interrupts for this variant? This is qcom,ipq6018-dwc3, not 5332. Read carefully how the file is currently organized - there is no entry which has clocks and interrupts at one place. You are bringing inconsistency, why? > > - if: > properties: > @@ -442,7 +449,6 @@ allOf: > compatible: > contains: > enum: > - - qcom,ipq5332-dwc3 > - qcom,x1e80100-dwc3 So now 5332 does not have any constraints. > then: > properties: Best regards, Krzysztof
On Thu, Jul 18, 2024 at 08:23:28AM +0200, Krzysztof Kozlowski wrote: > On 17/07/2024 11:48, Varadarajan Narayanan wrote: > > IPQ5332 has only three interrupts. Update the constraints > > to fix the following dt_binding_check errors. > > > > interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > > > > Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding") > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > v2: Fix patch version numbering. Incorrectly marked the first version as v0 > > Add interrupts and interrupt-names for ipq5332 instead of clubbing it with > > qcom,x1e80100-dwc3 > > --- > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > index 6c5f962bbcf9..5e5cc2175526 100644 > > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > @@ -235,6 +235,13 @@ allOf: > > - const: core > > - const: sleep > > - const: mock_utmi > > + interrupts: > > + maxItems: 3 > > + interrupt-names: > > + items: > > + - const: pwr_event > > + - const: dp_hs_phy_irq > > + - const: dm_hs_phy_irq > > Why are you duplicating interrupts for this variant? This is > qcom,ipq6018-dwc3, not 5332. Read carefully how the file is currently > organized - there is no entry which has clocks and interrupts at one > place. You are bringing inconsistency, why? Sorry, something got mixed up while rebasing. Have posted v3, please take a look. Thanks Varada > > - if: > > properties: > > @@ -442,7 +449,6 @@ allOf: > > compatible: > > contains: > > enum: > > - - qcom,ipq5332-dwc3 > > - qcom,x1e80100-dwc3 > > So now 5332 does not have any constraints. > > > then: > > properties:
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index 6c5f962bbcf9..5e5cc2175526 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -235,6 +235,13 @@ allOf: - const: core - const: sleep - const: mock_utmi + interrupts: + maxItems: 3 + interrupt-names: + items: + - const: pwr_event + - const: dp_hs_phy_irq + - const: dm_hs_phy_irq - if: properties: @@ -442,7 +449,6 @@ allOf: compatible: contains: enum: - - qcom,ipq5332-dwc3 - qcom,x1e80100-dwc3 then: properties:
IPQ5332 has only three interrupts. Update the constraints to fix the following dt_binding_check errors. interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding") Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- v2: Fix patch version numbering. Incorrectly marked the first version as v0 Add interrupts and interrupt-names for ipq5332 instead of clubbing it with qcom,x1e80100-dwc3 --- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)