| Message ID | 20240715083245.80169-2-xtex@envs.net |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node | expand |
On 15/07/2024 10:32, Bingwu Zhang wrote: > From: Bingwu Zhang <xtexchooser@duck.com> > > Add pstore node to allow for retrieving crash logs. > > Tested-by: Bingwu Zhang <xtexchooser@duck.com> # on SM-G9008W (samsung-kltechn) Tested-by tags are provided by others, not by yourself. It's expected that you test youro own patches. Drop the tag. > Signed-off-by: Bingwu Zhang <xtexchooser@duck.com> > --- > .../qcom-msm8974pro-samsung-klte-common.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi > index b5443fd5b425..ff98b9362b0d 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi > @@ -126,6 +126,23 @@ led@3 { > }; > }; > > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Don't duplicate the nodes, but rather extend via phandle/label. Or at least drop duplicated properties. > + > + ramoops@3e8e0000 { > + compatible = "ramoops"; > + reg = <0x3e8e0000 0x200000>; > + Best regards, Krzysztof
On Monday, July 15, 2024 4:57:54 PM GMT+8 Krzysztof Kozlowski wrote: > Don't duplicate the nodes, but rather extend via phandle/label. Or at > least drop duplicated properties. I was referencing other qualcomm devices with ramoops enabled, such as qcom-msm8974-sony-xperia-rhine.dtsi & qcom-apq8064-asus-nexus7-flo.dts. They seem to have the same issue. Should I make another patch to change those? Best regards,
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi index b5443fd5b425..ff98b9362b0d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi @@ -126,6 +126,23 @@ led@3 { }; }; + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + ramoops@3e8e0000 { + compatible = "ramoops"; + reg = <0x3e8e0000 0x200000>; + + console-size = <0x100000>; + record-size = <0x10000>; + ftrace-size = <0x10000>; + pmsg-size = <0x80000>; + ecc-size = <8>; + }; + }; + vreg_wlan: wlan-regulator { compatible = "regulator-fixed";