| Message ID | 20240710-ls-dwc-v1-3-62f8cbed31d7@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: dwc3: add fsl,ls-dwc3 glue layer support | expand |
On Wed, Jul 10, 2024 at 07:02:24PM -0400, Frank Li wrote: > New usb glue layer driver support enable dma-coherent. So put dwc3 usb node > under glue layer node and enable dma-coherent. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 43 ++++++++++++++++---------- > 1 file changed, 26 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 70b8731029c4e..24b937032480f 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -615,24 +615,33 @@ gpio3: gpio@2320000 { > little-endian; > }; > > - usb0: usb@3100000 { > - compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > - reg = <0x0 0x3100000 0x0 0x10000>; > - interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; > - snps,dis_rxdet_inp3_quirk; > - snps,quirk-frame-length-adjustment = <0x20>; > - snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > - status = "disabled"; > - }; > + usb { > + compatible = "fsl,ls1028a-dwc3"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; No, the existing way is preferred unless you have actual glue/wrapper registers. Plus this breaks compatibility. > + > + usb0: usb@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; > + dma-coherent; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + status = "disabled"; > + };
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 70b8731029c4e..24b937032480f 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -615,24 +615,33 @@ gpio3: gpio@2320000 { little-endian; }; - usb0: usb@3100000 { - compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; - reg = <0x0 0x3100000 0x0 0x10000>; - interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; - snps,dis_rxdet_inp3_quirk; - snps,quirk-frame-length-adjustment = <0x20>; - snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; - status = "disabled"; - }; + usb { + compatible = "fsl,ls1028a-dwc3"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + usb0: usb@3100000 { + compatible = "snps,dwc3"; + reg = <0x0 0x3100000 0x0 0x10000>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; + dma-coherent; + snps,dis_rxdet_inp3_quirk; + snps,quirk-frame-length-adjustment = <0x20>; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; + status = "disabled"; + }; - usb1: usb@3110000 { - compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; - reg = <0x0 0x3110000 0x0 0x10000>; - interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>; - snps,dis_rxdet_inp3_quirk; - snps,quirk-frame-length-adjustment = <0x20>; - snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; - status = "disabled"; + usb1: usb@3110000 { + compatible = "snps,dwc3"; + reg = <0x0 0x3110000 0x0 0x10000>; + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>; + dma-coherent; + snps,dis_rxdet_inp3_quirk; + snps,quirk-frame-length-adjustment = <0x20>; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; + status = "disabled"; + }; }; sata: sata@3200000 {
New usb glue layer driver support enable dma-coherent. So put dwc3 usb node under glue layer node and enable dma-coherent. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 43 ++++++++++++++++---------- 1 file changed, 26 insertions(+), 17 deletions(-)