| Message ID | 20240709-add_qcs9100_tlmm_compatible-v2-2-d025b58ea196@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: qcom: Add the QCS9100 tlmm compatible | expand |
On 7/9/2024 11:39 PM, Bartosz Golaszewski wrote: > On Tue, 9 Jul 2024 at 15:05, Tengfei Fan <quic_tengfan@quicinc.com> wrote: >> >> Add the tlmm driver support for QCS9100 platform. >> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >> platform use non-SCMI resource. In the future, the SA8775p platform will >> move to use SCMI resources and it will have new sa8775p-related device >> tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device >> match table. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c >> index 5459c0c681a2..4687e11dfe75 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c >> +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c >> @@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id sa8775p_pinctrl_of_match[] = { >> + { .compatible = "qcom,qcs9100-tlmm", }, >> { .compatible = "qcom,sa8775p-tlmm", }, >> { }, >> }; >> >> -- >> 2.25.1 >> > > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore the current patche here. Thank you for your input.
diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c index 5459c0c681a2..4687e11dfe75 100644 --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c @@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev) } static const struct of_device_id sa8775p_pinctrl_of_match[] = { + { .compatible = "qcom,qcs9100-tlmm", }, { .compatible = "qcom,sa8775p-tlmm", }, { }, };
Add the tlmm driver support for QCS9100 platform. QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p platform use non-SCMI resource. In the future, the SA8775p platform will move to use SCMI resources and it will have new sa8775p-related device tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device match table. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 + 1 file changed, 1 insertion(+)