| Message ID | 20240709063620.4125951-1-quic_varada@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] pci: qcom: Fix 'opp' variable usage | expand |
On Tue, Jul 09, 2024 at 12:06:20PM +0530, Varadarajan Narayanan wrote: > qcom_pcie_icc_opp_update() calls 'dev_pm_opp_put(opp)' regardless > of the success of dev_pm_opp_find_freq_exact(). > > If dev_pm_opp_find_freq_exact() had failed and 'opp' had some > error value, the subsequent dev_pm_opp_put(opp) results in a > crash. Hence call dev_pm_opp_put(opp) only if 'opp' has a valid > value. > > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> Fix was already submitted: https://lore.kernel.org/linux-pci/20240708180539.1447307-3-dan.carpenter@linaro.org/ - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 26405fcfa499..2a80d4499c25 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1443,8 +1443,8 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie) > if (ret) > dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", > freq_kbps * width, ret); > + dev_pm_opp_put(opp); > } > - dev_pm_opp_put(opp); > } > } > > -- > 2.34.1 >
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 26405fcfa499..2a80d4499c25 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1443,8 +1443,8 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie) if (ret) dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", freq_kbps * width, ret); + dev_pm_opp_put(opp); } - dev_pm_opp_put(opp); } }
qcom_pcie_icc_opp_update() calls 'dev_pm_opp_put(opp)' regardless of the success of dev_pm_opp_find_freq_exact(). If dev_pm_opp_find_freq_exact() had failed and 'opp' had some error value, the subsequent dev_pm_opp_put(opp) results in a crash. Hence call dev_pm_opp_put(opp) only if 'opp' has a valid value. Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- drivers/pci/controller/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)